1508987 - Enable ESLint for dom/svg/

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Mark Banner (:standard8)]

As part of rolling out ESLint across the tree, we should enable it for dom/svg/.

Comment 1

[Deepanjali]

Hello Mark! I would like to work on this bug.

Comment 2

[Deepanjali]

Hello Mark,
I am getting the following error :-

/Users/Deepanjali/mozilla-central/dom/svg/test/test_nonAnimStrings.xhtml
  21:5  error  Parsing error: Unexpected token <  (eslint)

Code looks like this :-

 20   <script id="script">
 21     <animate attributeName="xlink:href" from="" to="animated" dur="0.5s" begin="1s" fill="freeze" id="animate"/>
 22   </script>

I don't understand why it is testing an HTML element, which is correct. Please guide me on how to fix this issue.

Comment 3

[Mark Banner (:standard8)]

Hi Deepanjali, I think it is something that's intentional in the test - though I'm not quite sure why. I think the easiest thing to do for now is to ignore just this file. So go down to just under the dom/ section in .eslintignore and add something like:

# Intentionally invalid html
dom/svg/test/test_nonAnimStrings.xhtml

Comment 4

[Deepanjali]

Thank you Mark. The same error appears in another file, and I will do the same for it!

Comment 5

[Deepanjali]

Hello Mark, I lost access to my account so I created this new account. I have completely fixed this bug and just need to push the commits. Can you please assign this bug to my new account, so I can proceed.

Here is my email for this account: [e-mail]

Comment 6

[Mark Banner (:standard8)]

Unfortunately I've not heard from Deepanjali so unassigning for now.

Comment 7

[Shivam Singhal [ :championshuttler ]]

Hi Mark , Can I work on it if possible?

Thanks

Comment 8

[Mark Banner (:standard8)]

Sure.

Comment 9

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1508987 - Enable ESLint for dom/svg/ (Automatic Changes). r=standard8

Comment 10

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1508987 - Enable ESLint for dom/svg/ (Manual Changes). r=standard8

Depends on D22293

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69b00bf72f9e
Enable ESLint for dom/svg/ (Automatic Changes). r=jwatt
https://hg.mozilla.org/integration/autoland/rev/772847bbb314
Enable ESLint for dom/svg/ (Manual Changes). r=jwatt

Comment 12

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/69b00bf72f9e
https://hg.mozilla.org/mozilla-central/rev/772847bbb314