1508988 - Enable ESLint for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Mark Banner (:standard8)]

As part of rolling out ESLint across the tree, we should enable it for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/.

Comment 1

[Alex Kong]

Hey Mark, I'll take a look at this issue! I'd appreciate it if you can assign it to me.

Comment 2

[Alex Kong]

Attachment: Bug 1508988 - Enable ESLint for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/ (automatic changes). r?standard8!

Comment 3

[Alex Kong]

Attachment: Bug 1508988 - Enable ESLint for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/ (manual changes). r?standard8!

Depends on D14131

Comment 4

[Mark Banner (:standard8)]

Alex, I've just realised there's no author information on these commits so we can't land them automatically. You'll need to do something like this:

$ hg histedit
<select to edit the first commit>
$ hg commit --amend --author "Alex Kong <[e-mail]>"
$ hg histedit --continue
$ hg commit --amend --author "Alex Kong <[e-mail]>"
$ moz-phab submit

That should provide the correct author information on the commits. You can see this if you go to one of the revisions in Phabricator, and look for the "Revision Contents" table, and under the "Commits" tab there is an author column.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b15b5b6dbce2
Enable ESLint for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/ (automatic changes). r=Standard8,nika
https://hg.mozilla.org/integration/autoland/rev/2326b807ec86
Enable ESLint for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/ (manual changes). r=Standard8,nika

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/b15b5b6dbce2
https://hg.mozilla.org/mozilla-central/rev/2326b807ec86