Closed Bug 1508988 Opened 2 years ago Closed 2 years ago

Enable ESLint for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox65 --- wontfix
firefox66 --- fixed

People

(Reporter: standard8, Assigned: jrkong.hfd)

References

Details

(Whiteboard: [seneca-eslint])

Attachments

(2 files)

As part of rolling out ESLint across the tree, we should enable it for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/.
Hey Mark, I'll take a look at this issue! I'd appreciate it if you can assign it to me.
Assignee: standard8 → jrkong.hfd
Alex, I've just realised there's no author information on these commits so we can't land them automatically. You'll need to do something like this:

$ hg histedit
<select to edit the first commit>
$ hg commit --amend --author "Alex Kong <myemail@example.com>"
$ hg histedit --continue
$ hg commit --amend --author "Alex Kong <myemail@example.com>"
$ moz-phab submit

That should provide the correct author information on the commits. You can see this if you go to one of the revisions in Phabricator, and look for the "Revision Contents" table, and under the "Commits" tab there is an author column.
Flags: needinfo?(jrkong.hfd)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b15b5b6dbce2
Enable ESLint for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/ (automatic changes). r=Standard8,nika
https://hg.mozilla.org/integration/autoland/rev/2326b807ec86
Enable ESLint for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/ (manual changes). r=Standard8,nika
https://hg.mozilla.org/mozilla-central/rev/b15b5b6dbce2
https://hg.mozilla.org/mozilla-central/rev/2326b807ec86
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Flags: needinfo?(jrkong.hfd)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.