Enable ESLint for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/

RESOLVED FIXED in Firefox 66

Status

()

P3
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: standard8, Assigned: jrkong.hfd)

Tracking

(Blocks: 1 bug)

Trunk
mozilla66
Points:
---

Firefox Tracking Flags

(firefox65 wontfix, firefox66 fixed)

Details

(Whiteboard: [seneca-eslint])

Attachments

(2 attachments)

As part of rolling out ESLint across the tree, we should enable it for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/.
Priority: -- → P3
(Assignee)

Comment 1

3 months ago
Hey Mark, I'll take a look at this issue! I'd appreciate it if you can assign it to me.
Assignee: standard8 → jrkong.hfd
(Assignee)

Comment 2

2 months ago
Created attachment 9030388 [details]
Bug 1508988 - Enable ESLint for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/ (automatic changes). r?standard8!
(Assignee)

Comment 3

2 months ago
Created attachment 9030389 [details]
Bug 1508988 - Enable ESLint for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/ (manual changes). r?standard8!

Depends on D14131
Alex, I've just realised there's no author information on these commits so we can't land them automatically. You'll need to do something like this:

$ hg histedit
<select to edit the first commit>
$ hg commit --amend --author "Alex Kong <myemail@example.com>"
$ hg histedit --continue
$ hg commit --amend --author "Alex Kong <myemail@example.com>"
$ moz-phab submit

That should provide the correct author information on the commits. You can see this if you go to one of the revisions in Phabricator, and look for the "Revision Contents" table, and under the "Commits" tab there is an author column.
Flags: needinfo?(jrkong.hfd)

Comment 5

2 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b15b5b6dbce2
Enable ESLint for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/ (automatic changes). r=Standard8,nika
https://hg.mozilla.org/integration/autoland/rev/2326b807ec86
Enable ESLint for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/ (manual changes). r=Standard8,nika

Comment 6

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b15b5b6dbce2
https://hg.mozilla.org/mozilla-central/rev/2326b807ec86
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Flags: needinfo?(jrkong.hfd)
status-firefox65: affected → wontfix
You need to log in before you can comment on or make changes to this bug.