Closed Bug 1508991 Opened 2 years ago Closed 2 years ago

Enable ESLint for dom/manifest

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox65 --- wontfix
firefox66 --- fixed

People

(Reporter: standard8, Assigned: jkmcgeoghan)

References

Details

(Whiteboard: [seneca-eslint])

Attachments

(2 files, 1 obsolete file)

Bug 1508991 - Enable ESLint for dom/manifest/ (manual changes)
47 bytes, text/x-phabricator-request
Details | Review
Bug 1508991 - Enable ESLint for dom/manifest/ (automatic changes)
47 bytes, text/x-phabricator-request
Details | Review 
As part of rolling out ESLint across the tree, we should enable it for dom/manifest.
May I work on this?
nevermind, I think someone else wants it.
Hi, I'd be interested in working on this bug.
Assignee: standard8 → jkmcgeoghan
Bug 1508991 - Enable ESLint for dom/manifest/ (manual changes)
Attachment #9027825 - Attachment is obsolete: true
Attachment #9028213 - Attachment description: Bug 1508991 - Enable ESLint for dom/manifest/ (automatic changes) → Bug 447937 - Enable ESLint for dom/manifest/ (automatic changes)
Attachment #9028212 - Attachment description: Bug 1508991 - Enable ESLint for dom/manifest/ (manual changes) → Bug 447937 - Enable ESLint for dom/manifest/ (manual changes)
Attachment #9028212 - Attachment description: Bug 447937 - Enable ESLint for dom/manifest/ (manual changes) → Bug 1508991 - Enable ESLint for dom/manifest/ (manual changes)
Attachment #9028213 - Attachment description: Bug 447937 - Enable ESLint for dom/manifest/ (automatic changes) → Bug 1508991 - Enable ESLint for dom/manifest/ (automatic changes)
Attachment #9028213 - Attachment description: Bug 1508991 - Enable ESLint for dom/manifest/ (automatic changes) → Bug 447937 - Enable ESLint for dom/manifest/ (automatic changes)
Attachment #9028212 - Attachment description: Bug 1508991 - Enable ESLint for dom/manifest/ (manual changes) → Bug 447937 - Enable ESLint for dom/manifest/ (manual changes)
Attachment #9028212 - Attachment description: Bug 447937 - Enable ESLint for dom/manifest/ (manual changes) → Bug 1508991 - Enable ESLint for dom/manifest/ (manual changes)
Attachment #9028213 - Attachment description: Bug 447937 - Enable ESLint for dom/manifest/ (automatic changes) → Bug 1508991 - Enable ESLint for dom/manifest/ (automatic changes)
Hi Julia, could you rebase the patch on top of the latest master? There are conflicts in .eslintignore.

I believe you should be able to do `hg pull --rebase` and it'll automatically rebase the commits with maybe a little bit of manual fixup for the .eslintignore.
Flags: needinfo?(jkmcgeoghan)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6204be7c53a1
Enable ESLint for dom/manifest/ (automatic changes) r=Standard8,Ehsan
https://hg.mozilla.org/integration/autoland/rev/bdc983513121
Enable ESLint for dom/manifest/ (manual changes) r=Standard8,Ehsan
https://hg.mozilla.org/mozilla-central/rev/6204be7c53a1
https://hg.mozilla.org/mozilla-central/rev/bdc983513121
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Congratulations Julia, we got it there eventually! Thank you for sticking with this.
Flags: needinfo?(jkmcgeoghan)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.