Enable ESLint for dom/manifest

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
7 months ago
3 months ago

People

(Reporter: standard8, Assigned: jkmcgeoghan)

Tracking

(Blocks 1 bug)

Trunk
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 wontfix, firefox66 fixed)

Details

(Whiteboard: [seneca-eslint])

Attachments

(2 attachments, 1 obsolete attachment)

Reporter

Description

7 months ago
As part of rolling out ESLint across the tree, we should enable it for dom/manifest.
Priority: -- → P3

Comment 1

7 months ago
May I work on this?

Comment 2

7 months ago
nevermind, I think someone else wants it.
Assignee

Comment 3

7 months ago
Hi, I'd be interested in working on this bug.
Reporter

Updated

7 months ago
Assignee: standard8 → jkmcgeoghan
Assignee

Comment 4

7 months ago
Bug 1508991 - Enable ESLint for dom/manifest/ (manual changes)
Attachment #9027825 - Attachment is obsolete: true
Attachment #9028213 - Attachment description: Bug 1508991 - Enable ESLint for dom/manifest/ (automatic changes) → Bug 447937 - Enable ESLint for dom/manifest/ (automatic changes)
Attachment #9028212 - Attachment description: Bug 1508991 - Enable ESLint for dom/manifest/ (manual changes) → Bug 447937 - Enable ESLint for dom/manifest/ (manual changes)
Attachment #9028212 - Attachment description: Bug 447937 - Enable ESLint for dom/manifest/ (manual changes) → Bug 1508991 - Enable ESLint for dom/manifest/ (manual changes)
Attachment #9028213 - Attachment description: Bug 447937 - Enable ESLint for dom/manifest/ (automatic changes) → Bug 1508991 - Enable ESLint for dom/manifest/ (automatic changes)
Attachment #9028213 - Attachment description: Bug 1508991 - Enable ESLint for dom/manifest/ (automatic changes) → Bug 447937 - Enable ESLint for dom/manifest/ (automatic changes)
Attachment #9028212 - Attachment description: Bug 1508991 - Enable ESLint for dom/manifest/ (manual changes) → Bug 447937 - Enable ESLint for dom/manifest/ (manual changes)
Attachment #9028212 - Attachment description: Bug 447937 - Enable ESLint for dom/manifest/ (manual changes) → Bug 1508991 - Enable ESLint for dom/manifest/ (manual changes)
Attachment #9028213 - Attachment description: Bug 447937 - Enable ESLint for dom/manifest/ (automatic changes) → Bug 1508991 - Enable ESLint for dom/manifest/ (automatic changes)
Reporter

Comment 7

7 months ago
Hi Julia, could you rebase the patch on top of the latest master? There are conflicts in .eslintignore.

I believe you should be able to do `hg pull --rebase` and it'll automatically rebase the commits with maybe a little bit of manual fixup for the .eslintignore.
Flags: needinfo?(jkmcgeoghan)

Comment 8

6 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6204be7c53a1
Enable ESLint for dom/manifest/ (automatic changes) r=Standard8,Ehsan
https://hg.mozilla.org/integration/autoland/rev/bdc983513121
Enable ESLint for dom/manifest/ (manual changes) r=Standard8,Ehsan

Comment 9

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6204be7c53a1
https://hg.mozilla.org/mozilla-central/rev/bdc983513121
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Reporter

Comment 10

6 months ago
Congratulations Julia, we got it there eventually! Thank you for sticking with this.
Flags: needinfo?(jkmcgeoghan)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.