Closed
Bug 1508991
Opened 6 years ago
Closed 6 years ago
Enable ESLint for dom/manifest
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla66
People
(Reporter: standard8, Assigned: jkmcgeoghan)
References
Details
(Whiteboard: [seneca-eslint])
Attachments
(2 files, 1 obsolete file)
As part of rolling out ESLint across the tree, we should enable it for dom/manifest.
|
||
Updated•6 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 3•6 years ago
|
||
Hi, I'd be interested in working on this bug.
|
Reporter | |
Updated•6 years ago
|
Assignee: standard8 → jkmcgeoghan
|
|
Assignee | |
Comment 4•6 years ago
|
||
Bug 1508991 - Enable ESLint for dom/manifest/ (manual changes)
|
||
Updated•6 years ago
|
Attachment #9027825 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•6 years ago
|
||
Depends on D13207
|
|
Assignee | |
Comment 6•6 years ago
|
||
|
|
||
Updated•6 years ago
|
Attachment #9028213 -
Attachment description: Bug 1508991 - Enable ESLint for dom/manifest/ (automatic changes) → Bug 447937 - Enable ESLint for dom/manifest/ (automatic changes)
|
|
||
Updated•6 years ago
|
Attachment #9028212 -
Attachment description: Bug 1508991 - Enable ESLint for dom/manifest/ (manual changes) → Bug 447937 - Enable ESLint for dom/manifest/ (manual changes)
|
|
||
Updated•6 years ago
|
Attachment #9028212 -
Attachment description: Bug 447937 - Enable ESLint for dom/manifest/ (manual changes) → Bug 1508991 - Enable ESLint for dom/manifest/ (manual changes)
|
|
||
Updated•6 years ago
|
Attachment #9028213 -
Attachment description: Bug 447937 - Enable ESLint for dom/manifest/ (automatic changes) → Bug 1508991 - Enable ESLint for dom/manifest/ (automatic changes)
|
|
||
Updated•6 years ago
|
Attachment #9028213 -
Attachment description: Bug 1508991 - Enable ESLint for dom/manifest/ (automatic changes) → Bug 447937 - Enable ESLint for dom/manifest/ (automatic changes)
|
|
||
Updated•6 years ago
|
Attachment #9028212 -
Attachment description: Bug 1508991 - Enable ESLint for dom/manifest/ (manual changes) → Bug 447937 - Enable ESLint for dom/manifest/ (manual changes)
|
|
||
Updated•6 years ago
|
Attachment #9028212 -
Attachment description: Bug 447937 - Enable ESLint for dom/manifest/ (manual changes) → Bug 1508991 - Enable ESLint for dom/manifest/ (manual changes)
|
|
||
Updated•6 years ago
|
Attachment #9028213 -
Attachment description: Bug 447937 - Enable ESLint for dom/manifest/ (automatic changes) → Bug 1508991 - Enable ESLint for dom/manifest/ (automatic changes)
|
|
Reporter | |
Comment 7•6 years ago
|
||
Hi Julia, could you rebase the patch on top of the latest master? There are conflicts in .eslintignore.
I believe you should be able to do `hg pull --rebase` and it'll automatically rebase the commits with maybe a little bit of manual fixup for the .eslintignore.
Flags: needinfo?(jkmcgeoghan)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6204be7c53a1
Enable ESLint for dom/manifest/ (automatic changes) r=Standard8,Ehsan
https://hg.mozilla.org/integration/autoland/rev/bdc983513121
Enable ESLint for dom/manifest/ (manual changes) r=Standard8,Ehsan
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6204be7c53a1
https://hg.mozilla.org/mozilla-central/rev/bdc983513121
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
|
|
Reporter | |
Comment 10•6 years ago
|
||
Congratulations Julia, we got it there eventually! Thank you for sticking with this.
Flags: needinfo?(jkmcgeoghan)
|
||
Updated•6 years ago
|
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•