Closed
Bug 1508999
Opened 6 years ago
Closed 6 years ago
Standardise CSS "transform property" parameters in marionette's html test codes
Categories
(Remote Protocol :: Marionette, defect, P5)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1441437
People
(Reporter: shivambalikondwar, Unassigned)
Details
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/70.0.3538.77 Chrome/70.0.3538.77 Safari/537.36
Steps to reproduce:
I was testing the firefox's marionette codes , my work was to shorten the html codes required .
So i tried to analyze the web pages in the these links
https://dxr.mozilla.org/mozilla-central/rev/default/testing/marionette/harness/marionette_harness/www/cssTransform.html
https://dxr.mozilla.org/mozilla-central/rev/default/testing/marionette/harness/marionette_harness/www/cssTransform2.html
This can be present in other code's as well
Actual results:
I found that the css transform property parameters aren't standardized
At one place :
https://dxr.mozilla.org/mozilla-central/rev/default/testing/marionette/harness/marionette_harness/www/cssTransform.html
you can see in the css transform property display width is shown in "px"
While at this next html code :
https://dxr.mozilla.org/mozilla-central/rev/default/testing/marionette/harness/marionette_harness/www/cssTransform2.html
It is shown in "%" at some places .
Expected results:
As these codes are written by vendor or any person .
The codes parameters should have used the same "unit" for specifying the css transform properties .
As far as the guidelines of writting html code ,there must only be a single unit to write/define a particular css field .
We use "px" in
https://dxr.mozilla.org/mozilla-central/rev/default/testing/marionette/harness/marionette_harness/www/cssTransform2.html
so that it remains consistent with device width/height , that are defined already defined
and change the "%" field to its "px" equivalent .
We stick to only one unit system to avoid any broken tests
Reporter | ||
Updated•6 years ago
|
Severity: normal → minor
Component: Untriaged → General
Priority: -- → P5
Comment 1•6 years ago
|
||
We are getting rid of this file on bug 1441437, so I don't see any need to fix it first.
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Component: General → Marionette
Keywords: html4,
html5,
pi-marionette-httpd
Product: Firefox → Testing
Resolution: --- → DUPLICATE
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•