1509030 - The X11 widget does not populate the graphics adapter annotations

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Gabriele Svelto [:gsvelto]]

The GfxInfo implementation for X11 does gather information about the graphics adapter but does not add the relevant annotations to crash report.

Interestingly enough it does declare the AddCrashReportAnnotations() method name but never implements it:

https://searchfox.org/mozilla-central/rev/55895c49f55073d82d977cb74ec1d3a71ae4b25f/widget/GfxInfoX11.h#77

On this topic, every widget seems to add the annotations on an ad-hoc basis so it might be worth generalizing it outside of the platform-specific code to cut on code duplication.

Comment 1

[Divyansh Sharma [:spiro]]

In AddCrashReportAnnotations() in windows/Gfxinfo.cpp, certain functions are specific to windows platform, how can I find their alternatives for linux?

Comment 2

[Gabriele Svelto [:gsvelto]]

As Ted pointed out on IRC we already gather some information from Linux by running the 'glxtest' program and reading it's output, see here:

https://searchfox.org/mozilla-central/rev/78cd247b5d7a08832f87d786541d3e2204842e8e/toolkit/xre/glxtest.cpp#105

The data is read in GfxInfo::GetData():

https://searchfox.org/mozilla-central/rev/78cd247b5d7a08832f87d786541d3e2204842e8e/widget/GfxInfoX11.cpp#47

The data retrieved from the program is parsed here:

https://searchfox.org/mozilla-central/rev/78cd247b5d7a08832f87d786541d3e2204842e8e/widget/GfxInfoX11.cpp#102-123

Finally we format it into a string and add it to the crash annotation notes:

https://searchfox.org/mozilla-central/rev/78cd247b5d7a08832f87d786541d3e2204842e8e/widget/GfxInfoX11.cpp#167-179

You would need to change this to add crash annotations instead. In particular the vendor string (mVendor) should be assigned to the AdapterVendorID annotation, the adapter description (mAdapterDescription) should go into the AdapterDeviceID and finally the vendor string into the AdapterDriverVersion annotation.

It would also be best if the annotations themselves would be moved into the AddCrashReportAnnotations() method.

Comment 3

[Divyansh Sharma [:spiro]]

Attachment: Bug 1509030 : The X11 widget populate graphics adapter annotations through AddCrashReportAnnotations()

Bug 1509030 : The X11 widget populate graphics adapter annotations through AddCrashReportAnnotations()

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/integration/autoland/rev/7251061fa1dc

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7251061fa1dc