1509038 - [remote-dbg-next] pushServiceWorker no longer working after switching to front

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Julian Descottes [:jdescottes]]

pushServiceWorker is still using the old client.request API

  await clientWrapper.request({ to: actor, type: "push" });

However here actor is now null, because the target id is no longer defined for workers. We are reintroducing id in Bug 1500005, however we still need to switch to workerTargetFront.push();

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1509038 - Listen to worker updates on contentProcess fronts;r=daisuke

This is a followup to Bug 1506549 where some of the frontend
code was migrated to listen to worker updates on the content process fronts.
The current about:debugging was migrated, but not the new one.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1509038 - Use worker front push() in aboutdebugging-new;r=daisuke

Depends on D14074

The current code using request works now that actor points to a real
actor ID, so this doesn't really fix anything. It is a cleanup because we should
move away from using the request API. Also the current about:debugging uses
front.push() so this is better for consistency.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1509038 - Set allowChromeProcess to true when starting local DebuggerServer;r=daisuke

Depends on D14075.

allowChromeProcess will allow to retrieve workers from children processes

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1509038 - Port serviceworker push test to new about:debugging;r=daisuke

Depends on D14077

This test is a conversion of devtools/client/aboutdebugging/test/browser_service_workers_push.js
It turns out I forgot to file a bug to migrate this test, so doing it here.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88e3a35b9cfd
Listen to worker updates on contentProcess fronts;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/16264280c0ee
Use worker front push() in aboutdebugging-new;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/2270b8df4dc6
Set allowChromeProcess to true when starting local DebuggerServer;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/25d0bf121f26
Port serviceworker push test to new about:debugging;r=daisuke

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: fix_clientwrapper_mock.patch

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1509038 - Update client wrapper mocks;r=ladybenko

Depends on D14078

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ed80c7a5ce9
Update client wrapper mocks;r=ladybenko

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/88e3a35b9cfd
https://hg.mozilla.org/mozilla-central/rev/16264280c0ee
https://hg.mozilla.org/mozilla-central/rev/2270b8df4dc6
https://hg.mozilla.org/mozilla-central/rev/25d0bf121f26
https://hg.mozilla.org/mozilla-central/rev/1ed80c7a5ce9