Closed Bug 1509038 Opened 5 years ago Closed 5 years ago

[remote-dbg-next] pushServiceWorker no longer working after switching to front


(DevTools :: about:debugging, enhancement, P1)



(firefox66 fixed)

Firefox 66
Tracking Status
firefox66 --- fixed


(Reporter: jdescottes, Assigned: jdescottes)


(Blocks 1 open bug)



(6 files)

pushServiceWorker is still using the old client.request API

  await clientWrapper.request({ to: actor, type: "push" });

However here actor is now null, because the target id is no longer defined for workers. We are reintroducing id in Bug 1500005, however we still need to switch to workerTargetFront.push();
Priority: -- → P2
Assignee: nobody → jdescottes
Priority: P2 → P1
This is a followup to Bug 1506549 where some of the frontend
code was migrated to listen to worker updates on the content process fronts.
The current about:debugging was migrated, but not the new one.
Depends on D14074

The current code using request works now that actor points to a real
actor ID, so this doesn't really fix anything. It is a cleanup because we should
move away from using the request API. Also the current about:debugging uses
front.push() so this is better for consistency.
Depends on D14075.

allowChromeProcess will allow to retrieve workers from children processes
Depends on D14077

This test is a conversion of devtools/client/aboutdebugging/test/browser_service_workers_push.js
It turns out I forgot to file a bug to migrate this test, so doing it here.
Pushed by
Listen to worker updates on contentProcess fronts;r=daisuke
Use worker front push() in aboutdebugging-new;r=daisuke
Set allowChromeProcess to true when starting local DebuggerServer;r=daisuke
Port serviceworker push test to new about:debugging;r=daisuke
Pushed by
Update client wrapper mocks;r=ladybenko
You need to log in before you can comment on or make changes to this bug.