1509099 - Hit MOZ_CRASH(Manual eviction requires cleanup) at gfx/webrender/src/resource_cache.rs:165

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Tyson Smith [:tsmith]]

Attachment: testcase.html

Reduced with m-c:
BuildID=20181120164749
SourceStamp=8eff0a4f5d8f4442ce233d492185a90c460846ef

Hit MOZ_CRASH(Manual eviction requires cleanup) at gfx/webrender/src/resource_cache.rs:165

#0 MOZ_CrashOOL(char const*, int, char const*) src/obj-firefox/dist/include/mozilla/Assertions.h:311:3
#1 GeckoCrashOOL src/toolkit/xre/nsAppRunner.cpp:5350:3
#2 gkrust_shared::panic_hook::h656ed0b38bd6bc6d src/toolkit/library/rust/shared/lib.rs:234:8
#3 core::ops::function::Fn::call::h7805ce02ed763bba src/libcore/ops/function.rs:78:4
#4 std::panicking::rust_panic_with_hook::h0e12cb2fc86d00fa /rustc/da5f414c2c0bfe5198934493f04c676e2b23ff2e/src/libstd/panicking.rs:481:16
#5 std::panicking::begin_panic::hf7810071ea595708 src/libstd/panicking.rs:411:4
#6 _$LT$webrender..resource_cache..CachedImageInfo$u20$as$u20$core..ops..drop..Drop$GT$::drop::h3101e1d8a58d3510 src/gfx/webrender/src/resource_cache.rs:165:8
#7 core::ptr::drop_in_place::h6b2118650a792e8c src/libcore/ptr.rs:59
#8 _$LT$std..collections..hash..map..HashMap$LT$K$C$$u20$V$C$$u20$S$GT$$GT$::retain::h8cfc0cdac97c0d35 src/libstd/collections/hash/map.rs:1471
#9 _$LT$webrender..resource_cache..ResourceClassCache$LT$K$C$$u20$V$C$$u20$U$GT$$GT$::retain::he3da0ff0bca9f446 src/gfx/webrender/src/resource_cache.rs:270:8
#10 webrender::resource_cache::ResourceCache::discard_tiles_outside_visible_area::h55c71000a3346296 src/gfx/webrender/src/resource_cache.rs:1211
#11 webrender::resource_cache::ResourceCache::post_scene_building_update::hd9fb9808b21c9032 src/gfx/webrender/src/resource_cache.rs:529
#12 webrender::render_backend::RenderBackend::update_document::h2411895f02eb6f28 src/gfx/webrender/src/render_backend.rs:1173:8
#13 webrender::render_backend::RenderBackend::run::hc7c3f13760f6d726 src/gfx/webrender/src/render_backend.rs:766:24
#14 webrender::renderer::Renderer::new::_$u7b$$u7b$closure$u7d$$u7d$::h118322e7a5f57d4f src/gfx/webrender/src/renderer.rs:1951:12
#15 std::sys_common::backtrace::__rust_begin_short_backtrace::h4690b5b93940c612 src/libstd/sys_common/backtrace.rs:136
#16 std::thread::Builder::spawn::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h60b4a4c67de8111a src/libstd/thread/mod.rs:409:20
#17 _$LT$std..panic..AssertUnwindSafe$LT$F$GT$$u20$as$u20$core..ops..function..FnOnce$LT$$LP$$RP$$GT$$GT$::call_once::h0a79177324334219 src/libstd/panic.rs:313
#18 std::panicking::try::do_call::hac5779da819c8173 src/libstd/panicking.rs:310
#19 __rust_maybe_catch_panic /rustc/da5f414c2c0bfe5198934493f04c676e2b23ff2e/src/libpanic_abort/lib.rs:41:4

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Assertion added in bug 1499908. Bobby, can you take a look?

Comment 2

[Bobby Holley (:bholley)]

This broke in bug 1499908 / https://github.com/servo/webrender/pull/3250 .

Patch forthcoming.

Comment 3

[Bobby Holley (:bholley)]

Attachment: Bug 1509099 - Route mark_unused through a helper.

Comment 4

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c21db73a5c0ccfd6ed7e85ddf066638a3eada59

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Doesn't look like this ever landed, did you mean to push it upstream?

Comment 6

[Bobby Holley (:bholley)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #5)
> Doesn't look like this ever landed, did you mean to push it upstream?

It was r+ed yesterday afternoon and I got busy with a few things and didn't push it. Here it is now: https://github.com/servo/webrender/pull/3410

Note to self to remember to push the crashtest.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

(In reply to Bobby Holley (:bholley) from comment #6)
> It was r+ed yesterday afternoon

Whoops, I didn't see the timestamp on that, just looked at the activity on the bug which was a few weeks old.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aec6d3745e4f
Crashtest. r=me

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/aec6d3745e4f

Comment 10

[Ryan VanderMeulen [:RyanVM]]

I'm assuming this can just ride the trains since it wasn't a crash seen in the wild, but feel free to nominate for uplift if you think we should still.