Closed Bug 1509135 Opened Last year Closed Last year

Only define UnregisterCallback once

Categories

(Core :: DOM: Service Workers, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: perry, Assigned: perry)

References

Details

Attachments

(1 file)

UnregisterCallback is defined/implemented in both ServiceWorkerRegistrationImpl.cpp and ServiceWorkerRegistrationProxy.cpp, and both implementations are essentially the same.

While this isn't a current issue, because the definitions are ultimately placed in separate Unified_cpp_dom_serviceworkers<N>.cpp files, adding to UNIFIED_SOURCES in dom/serviceworkers/moz.build can cause the two definitions to be placed in the same file.
Assignee: nobody → perry
Blocks: 1231213
Priority: -- → P3
Keywords: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/21bc8b9a89ac
Only define UnregisterCallback once r=mrbkap
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/21bc8b9a89ac
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.