1509135 - Only define UnregisterCallback once

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect, P3)

Description

[Perry Jiang [:perry] [no longer employee, use ni?]]

UnregisterCallback is defined/implemented in both ServiceWorkerRegistrationImpl.cpp and ServiceWorkerRegistrationProxy.cpp, and both implementations are essentially the same.

While this isn't a current issue, because the definitions are ultimately placed in separate Unified_cpp_dom_serviceworkers<N>.cpp files, adding to UNIFIED_SOURCES in dom/serviceworkers/moz.build can cause the two definitions to be placed in the same file.

Comment 1

[Perry Jiang [:perry] [no longer employee, use ni?]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=546db674c95e52849216ddc5e7e0fcb5218499c6

Comment 2

[Perry Jiang [:perry] [no longer employee, use ni?]]

Attachment: Bug 1509135 - Only define UnregisterCallback once r?mrbkap

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21bc8b9a89ac
Only define UnregisterCallback once r=mrbkap

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/21bc8b9a89ac