1509140 - Sending/copying this URL trims trailing "-16470894"

Status: RESOLVED FIXED

(Firefox for iOS :: General, enhancement, P2)

Description

[Andrew Overholt [:overholt]]

https://me.me/i/savage-department-randy-speaking-none-16470894

Sharing it via iMessage or copying the URL or even sending to my desktop, it always ends up trimming it to become https://me.me/i/savage-department-randy-speaking-none which isn't correct.

iOS 12.1, Firefox for iOS Beta (14.0, build 12646)

Comment 1

[Justin D'Arcangelo [:justindarc]]

So, when we grab the URL for sending to external applications, we use the canonical URL from the page metadata (if exists). In the above example, it looks like the website is supplying an invalid URL:

```
<meta property="og:url" content="http://me.me/i/savage-department-randy-speaking-none"/>
```

So, that's where the wrong URL is coming from :-/

It is arguable whether or not we should do this though or if we should just always use the URL as-is. I believe this was originally done to avoid sharing AMP links to desktop.

Comment 2

[Justin D'Arcangelo [:justindarc]]

I'm going to take this bug and change our logic to only grab the `og:url` from the page metadata for AMP pages ONLY. All other sites, we should just grab the URL from the address bar as-is.

Comment 3

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/pull/4405

Comment 4

[Justin D'Arcangelo [:justindarc]]

https://github.com/mozilla-mobile/firefox-ios/commit/548083ad76e491c5ceadf9e369e85feac0022004