1509147 - Rename payer and paymentMethod on nsIPaymentDetails to payerErrors and paymentMethodErrors respectively

Status: RESOLVED FIXED

(Core :: DOM: Web Payments, defect, P1)

Description

[Matthew N. [:MattN]]

It's non-obvious that `nsIPaymentDetails.payer` or `nsIPaymentDetails.paymentMethod` actually contain errors, not information about the payer or paymentMethod. I had a hard time figuring out if these errors were passed to the front-end because of this. These should be renamed to add an "Errors" suffix to match `shippingAddressErrors`.

Front-end code and tests should be updated to reflect this.

Diego, would you prefer contributing to C++ or JS? This may be a good bug for you. Feel free to join #payments on irc.mozilla.org

Comment 1

[Diego Pino]

I have no preference. I like the idea of working on C++ code too, despite it has been a long time since I coded in C++. Possibly I can take simple C++ bugs like this one for a start.

Comment 2

[Diego Pino]

Attachment: Bug-1509147-Rename-payer-and-paymentMethod-on-nsIPay.patch

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 9026932 [details] [diff] [review]
Bug-1509147-Rename-payer-and-paymentMethod-on-nsIPay.patch

Review of attachment 9026932 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great! I'll request DOM peer review now too. Thanks

Comment 4

[Matthew N. [:MattN]]

Make sure to run `./mach test dom/payments` too.

Comment 5

[Diego Pino]

Attachment: Bug-1509147-Rename-payer-and-paymentMethod-on-nsIPay.patch

Update patch (`dom/payments/test/test_basiccarderrors.html` failed).

Comment 6

[Diego Pino]

Attachment: Bug-1509147-Rename-payer-and-paymentMethod-on-nsIPay.patch

Comment 7

[Diego Pino]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=667e4d557665bbf60d2e02bb66c16b58e3e0792e

Comment 8

[Diego Pino]

Attachment: Bug-1509147-Rename-payer-and-paymentMethod-on-nsIPay.patch

Updated patch (`dom/payments/test/test_payerDetails.html` failed).

Comment 9

[Diego Pino]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=71a543fd3f73951d3c3ffe207ef6465bcc845d53

Comment 10

[Diego Pino]

Attachment: Bug-1509147-Rename-payer-and-paymentMethod-on-nsIPay.patch

Fixed failing test `test_retryPayment.html`.

Comment 11

[Diego Pino]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2641f93aa57d0c353a34aa9e1446a71aad4c2e9

Comment 12

[Diego Pino]

After this many back and forth patch updates, I think the patch is ready for review now (no tests failing).

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9a02a8a62e5
Rename payer and paymentMethod on nsIPaymentDetails to payerErrors and paymentMethodErrors respectively r=baku

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e9a02a8a62e5