Closed
Bug 1509147
Opened 5 years ago
Closed 5 years ago
Rename payer and paymentMethod on nsIPaymentDetails to payerErrors and paymentMethodErrors respectively
Categories
(Core :: DOM: Web Payments, defect, P1)
Core
DOM: Web Payments
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: MattN, Assigned: dpino)
References
()
Details
(Whiteboard: [webpayments-reserve])
Attachments
(1 file, 4 obsolete files)
17.43 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
It's non-obvious that `nsIPaymentDetails.payer` or `nsIPaymentDetails.paymentMethod` actually contain errors, not information about the payer or paymentMethod. I had a hard time figuring out if these errors were passed to the front-end because of this. These should be renamed to add an "Errors" suffix to match `shippingAddressErrors`. Front-end code and tests should be updated to reflect this. Diego, would you prefer contributing to C++ or JS? This may be a good bug for you. Feel free to join #payments on irc.mozilla.org
Flags: needinfo?(dpino)
Assignee | ||
Comment 1•5 years ago
|
||
I have no preference. I like the idea of working on C++ code too, despite it has been a long time since I coded in C++. Possibly I can take simple C++ bugs like this one for a start.
Flags: needinfo?(dpino)
Assignee | ||
Comment 2•5 years ago
|
||
Attachment #9026932 -
Flags: review?(MattN+bmo)
Updated•5 years ago
|
Assignee: nobody → dpino
Status: NEW → ASSIGNED
Priority: P3 → P1
Reporter | ||
Comment 3•5 years ago
|
||
Comment on attachment 9026932 [details] [diff] [review] Bug-1509147-Rename-payer-and-paymentMethod-on-nsIPay.patch Review of attachment 9026932 [details] [diff] [review]: ----------------------------------------------------------------- Looks great! I'll request DOM peer review now too. Thanks
Attachment #9026932 -
Flags: review?(amarchesini)
Attachment #9026932 -
Flags: review?(MattN+bmo)
Attachment #9026932 -
Flags: review+
Reporter | ||
Comment 4•5 years ago
|
||
Make sure to run `./mach test dom/payments` too.
Assignee | ||
Comment 5•5 years ago
|
||
Update patch (`dom/payments/test/test_basiccarderrors.html` failed).
Attachment #9026932 -
Attachment is obsolete: true
Attachment #9026932 -
Flags: review?(amarchesini)
Assignee | ||
Comment 6•5 years ago
|
||
Attachment #9027018 -
Attachment is obsolete: true
Attachment #9027020 -
Flags: review?(amarchesini)
Assignee | ||
Comment 7•5 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=667e4d557665bbf60d2e02bb66c16b58e3e0792e
Assignee | ||
Comment 8•5 years ago
|
||
Updated patch (`dom/payments/test/test_payerDetails.html` failed).
Attachment #9027020 -
Attachment is obsolete: true
Attachment #9027020 -
Flags: review?(amarchesini)
Attachment #9027105 -
Flags: review?(amarchesini)
Assignee | ||
Comment 9•5 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=71a543fd3f73951d3c3ffe207ef6465bcc845d53
Assignee | ||
Comment 10•5 years ago
|
||
Fixed failing test `test_retryPayment.html`.
Attachment #9027105 -
Attachment is obsolete: true
Attachment #9027105 -
Flags: review?(amarchesini)
Attachment #9027480 -
Flags: review?(amarchesini)
Assignee | ||
Comment 11•5 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2641f93aa57d0c353a34aa9e1446a71aad4c2e9
Assignee | ||
Comment 12•5 years ago
|
||
After this many back and forth patch updates, I think the patch is ready for review now (no tests failing).
Updated•5 years ago
|
Attachment #9027480 -
Flags: review?(amarchesini) → review+
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Comment 13•5 years ago
|
||
Pushed by rmaries@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e9a02a8a62e5 Rename payer and paymentMethod on nsIPaymentDetails to payerErrors and paymentMethodErrors respectively r=baku
Keywords: checkin-needed
Comment 14•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e9a02a8a62e5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Updated•5 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•