Rename payer and paymentMethod on nsIPaymentDetails to payerErrors and paymentMethodErrors respectively

RESOLVED FIXED in Firefox 65

Status

()

defect
P1
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: MattN, Assigned: dpino)

Tracking

unspecified
mozilla65
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox65 fixed)

Details

(Whiteboard: [webpayments-reserve], )

Attachments

(1 attachment, 4 obsolete attachments)

It's non-obvious that `nsIPaymentDetails.payer` or `nsIPaymentDetails.paymentMethod` actually contain errors, not information about the payer or paymentMethod. I had a hard time figuring out if these errors were passed to the front-end because of this. These should be renamed to add an "Errors" suffix to match `shippingAddressErrors`.

Front-end code and tests should be updated to reflect this.

Diego, would you prefer contributing to C++ or JS? This may be a good bug for you. Feel free to join #payments on irc.mozilla.org
Flags: needinfo?(dpino)
Assignee

Comment 1

7 months ago
I have no preference. I like the idea of working on C++ code too, despite it has been a long time since I coded in C++. Possibly I can take simple C++ bugs like this one for a start.
Flags: needinfo?(dpino)
Assignee

Comment 2

7 months ago
Attachment #9026932 - Flags: review?(MattN+bmo)
Assignee: nobody → dpino
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment on attachment 9026932 [details] [diff] [review]
Bug-1509147-Rename-payer-and-paymentMethod-on-nsIPay.patch

Review of attachment 9026932 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great! I'll request DOM peer review now too. Thanks
Attachment #9026932 - Flags: review?(amarchesini)
Attachment #9026932 - Flags: review?(MattN+bmo)
Attachment #9026932 - Flags: review+
Make sure to run `./mach test dom/payments` too.
Assignee

Comment 5

7 months ago
Update patch (`dom/payments/test/test_basiccarderrors.html` failed).
Attachment #9026932 - Attachment is obsolete: true
Attachment #9026932 - Flags: review?(amarchesini)
Assignee

Comment 6

7 months ago
Attachment #9027018 - Attachment is obsolete: true
Attachment #9027020 - Flags: review?(amarchesini)
Assignee

Comment 8

7 months ago
Updated patch (`dom/payments/test/test_payerDetails.html` failed).
Attachment #9027020 - Attachment is obsolete: true
Attachment #9027020 - Flags: review?(amarchesini)
Attachment #9027105 - Flags: review?(amarchesini)
Assignee

Comment 10

7 months ago
Fixed failing test `test_retryPayment.html`.
Attachment #9027105 - Attachment is obsolete: true
Attachment #9027105 - Flags: review?(amarchesini)
Attachment #9027480 - Flags: review?(amarchesini)
Assignee

Comment 12

7 months ago
After this many back and forth patch updates, I think the patch is ready for review now (no tests failing).
Attachment #9027480 - Flags: review?(amarchesini) → review+
Assignee

Updated

7 months ago
Keywords: checkin-needed

Comment 13

7 months ago
Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9a02a8a62e5
Rename payer and paymentMethod on nsIPaymentDetails to payerErrors and paymentMethodErrors respectively r=baku
Keywords: checkin-needed

Comment 14

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e9a02a8a62e5
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.