1509196 - Minor nsCSSFrameConstructor cleanup

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

During the investigation of bug 1507244, I found something that might worth a bit of cleanup.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1509196 - Remove unused variable isFlexOrGridContainer in ProcessChildren(). r?dholbert,mats

The other uses of isFlexOrGridContainer were removed in
https://hg.mozilla.org/mozilla-central/rev/fa81899efb5e

We can rely on ShouldSuppressFloatingOfDescendants() to look
IsFlexOrGridContainer() up.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1509196 - Remove ::IsFlexOrGridContainer(). r?dholbert,mats

This is equivalent to nsIFrame::IsFlexOrGridContainer().

Depends on D12609

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1509196 - Remove #ifdef NOISY_FINDFRAME. r?dholbert,mats

The code using FFWC_* variables was removed in
https://hg.mozilla.org/mozilla-central/rev/e4438ed238da

Depends on D12610

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78b17ef09393
Remove unused variable isFlexOrGridContainer in ProcessChildren(). r=mats
https://hg.mozilla.org/integration/autoland/rev/c00a2da3c2af
Remove ::IsFlexOrGridContainer(). r=mats
https://hg.mozilla.org/integration/autoland/rev/7efb1e74bf4f
Remove #ifdef NOISY_FINDFRAME. r=mats

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/78b17ef09393
https://hg.mozilla.org/mozilla-central/rev/c00a2da3c2af
https://hg.mozilla.org/mozilla-central/rev/7efb1e74bf4f