Closed Bug 1509196 Opened 11 months ago Closed 11 months ago

Minor nsCSSFrameConstructor cleanup

Categories

(Core :: Layout, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

Details

Attachments

(3 files)

During the investigation of bug 1507244, I found something that might worth a bit of cleanup.
The other uses of isFlexOrGridContainer were removed in
https://hg.mozilla.org/mozilla-central/rev/fa81899efb5e

We can rely on ShouldSuppressFloatingOfDescendants() to look
IsFlexOrGridContainer() up.
This is equivalent to nsIFrame::IsFlexOrGridContainer().

Depends on D12609
The code using FFWC_* variables was removed in
https://hg.mozilla.org/mozilla-central/rev/e4438ed238da

Depends on D12610
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/78b17ef09393
Remove unused variable isFlexOrGridContainer in ProcessChildren(). r=mats
https://hg.mozilla.org/integration/autoland/rev/c00a2da3c2af
Remove ::IsFlexOrGridContainer(). r=mats
https://hg.mozilla.org/integration/autoland/rev/7efb1e74bf4f
Remove #ifdef NOISY_FINDFRAME. r=mats
https://hg.mozilla.org/mozilla-central/rev/78b17ef09393
https://hg.mozilla.org/mozilla-central/rev/c00a2da3c2af
https://hg.mozilla.org/mozilla-central/rev/7efb1e74bf4f
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.