Closed Bug 1509321 Opened 11 months ago Closed 11 months ago

Dark/Light theme tabbar icons color is not the same as with the default theme

Categories

(Firefox :: Theme, defect, P3)

Unspecified
Windows 10
defect

Tracking

()

VERIFIED FIXED
Firefox 65
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- unaffected
firefox64 --- unaffected
firefox65 --- verified

People

(Reporter: itiel_yn8, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(4 files, 1 obsolete file)

This is a regression from (mainly) bug 1505311 and bug 1507574 (which fixed the color inconsistency in the tabbar).

STR:
1. Make sure you're on the default theme, observe the tabbar icons color
2. Switch to the Dark/Light theme, observe the tabbar icons color

AR:
They are not the same. On my Nightly the color is grey-ish for the default theme and white for the Dark/Light theme.

ER:
According to :dao in bug 1507574 comment 21, the color should be the same as with the default theme when both use the same titlebar background.

See attached screenshots.
Attached image Default theme
Attached image Light theme (obsolete) —
Attached image Dark theme
Attached image Light theme
Attachment #9026968 - Attachment is obsolete: true
Assignee: nobody → dao+bmo
OS: Unspecified → Windows 10
Priority: -- → P3
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd8847c43e0d
Use default --toolbarbutton-icon-fill-opacity when overriding --lwt-toolbarbutton-icon-fill in the titlebar. r=ntim
https://hg.mozilla.org/mozilla-central/rev/fd8847c43e0d
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Looking good on latest Nightly.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.