Closed
Bug 1509333
Opened 5 years ago
Closed 5 years ago
The "Dismiss" button is wrongly displayed in the right part of a snippet on the RTL Firefox locales
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
VERIFIED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox63 | --- | unaffected |
firefox64 | --- | fixed |
firefox65 | --- | verified |
People
(Reporter: mcoman, Assigned: andreio)
References
Details
Attachments
(1 file)
2.77 MB,
image/gif
|
Details |
Affected versions]: - Firefox 64 and above [Affected Platforms]: - All Windows - All Linux - All Mac [Prerequisites]: - Have the Firefox AR locale build installed. - Have a Firefox profile with the following prefs in the "about:config" page: - "browser.newtabpage.activity-stream.asrouterExperimentEnabled" with "true" value; [Steps to reproduce]: 1. Open the browser with the profile from prerequisites. 2. Navigate to "about:newtab#asrouter" page. 3. Scroll down to the "NEWSLETTER_TEST_1" section and click the "Show" button. 4. Click the "Continue" button and observe the position of the "Dismiss" button. [Expected result]: - The "Dismiss" button is displayed in the left part of the snippet. [Actual result]: - The "Dismiss" button is displayed in the right part of the snippet. [Additional Notes]: - Attached a screen recording of the issue.
Comment 1•5 years ago
|
||
It sounds like this is fixed as of latest nightly. Can you confirm?
Assignee: nobody → marius.coman
Flags: needinfo?(marius.coman)
Assignee | ||
Comment 2•5 years ago
|
||
Fixed in https://github.com/mozilla/activity-stream/commit/afc948a958ef90094e8b6b8d28c7ddef1a8faeca
Reporter | ||
Comment 3•5 years ago
|
||
I have verified that this issue is no longer reproducible with the latest Firefox Nightly AR locale build (65.0a1 Build ID - 20181126100057) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the "Dismiss" button is displayed in the left part of a snippet.
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(marius.coman)
Resolution: --- → FIXED
Reporter | ||
Updated•5 years ago
|
Status: RESOLVED → VERIFIED
Reporter | ||
Updated•5 years ago
|
Comment 4•5 years ago
|
||
Is this something we should consider uplifting to Beta before next week's RC?
Assignee: marius.coman → andrei.br92
Flags: needinfo?(andrei.br92)
Assignee | ||
Comment 5•5 years ago
|
||
Yes but this fix will be included as part of other Activity Stream exports so no tracking needed on this bug. Thanks.
Flags: needinfo?(andrei.br92)
Comment 6•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/973e2824df96
Target Milestone: --- → Firefox 65
Updated•5 years ago
|
Comment 7•5 years ago
|
||
Did this end up on 64, and if so, under which bug was it uplifted?
Flags: needinfo?(andrei.br92)
Comment 9•5 years ago
|
||
Yes, for 65. I was asking about 64 (per comment 4).
Flags: needinfo?(andrei.br92)
Assignee | ||
Comment 10•5 years ago
|
||
Sorry here is the correct bug https://bugzilla.mozilla.org/show_bug.cgi?id=1500563#c9
Flags: needinfo?(andrei.br92)
Comment 11•5 years ago
|
||
Thanks for the confirmation.
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•