1509346 - Add support for <form rel>

Status: RESOLVED FIXED

(Core :: DOM: Forms, enhancement, P2)

Description

[(no longer active)]

In a similar fashion to bug 1503681, we would like to experiment with breaking opener references for pages opened via form navigations.

On the related dev-platform thread, I said this about the spec side of things:
...it's impossible to block opener reference creation upon form submission right now as far as I can tell.  This is actually a bug in the spec.  <https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#form-submission-algorithm:the-rules-for-choosing-a-browsing-context-given-a-browsing-context-name> calls into "rules for choosing a browsing context" passing only two arguments, omitting the third one (noopener) <https://html.spec.whatwg.org/multipage/browsers.html#the-rules-for-choosing-a-browsing-context-given-a-browsing-context-name>.

The web compat risk here is unknown so it may make sense to land a pref that we can turn on first on Nightly and take things from there.

Comment 1

[Chris Mills [:cmills]]

Might require some docs updates somewhere along the line.

Comment 2

[Anne (:annevk)]

https://github.com/whatwg/html/pull/4332 details changes to the HTML Standard for this. Note that it also adds the rel content/IDL attribute and the relList IDL attribute, as well as support for noopener, noreferrer, and opener, for full parity with <a> and <area>.

Comment 3

[Anne (:annevk)]

Forgot to mention, I added tests in https://github.com/web-platform-tests/wpt/pull/15356.

Comment 4

[Karl Dubost💡 :karlcow]

There is no signal on real websites.

Comment 5

[Adam Vandolder [:avandolder]]

Attachment: Bug 1509346 - Add support for <form rel>. r?smaug

Comment 6

[Adam Vandolder [:avandolder]]

https://treeherder.mozilla.org/jobs?repo=try&revision=1d98915d4a29ee6a05fd5a848da611b2274c914f

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ad22146a015
Add support for <form rel>. r=smaug

Comment 8

[Sandor Molnar]

Backed out for causing for causing failures in docshell/base/nsDocShell.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/8b993ae70da999e10be45c74c940afb8185345e9

Push with failures

Failure log: Assertion failure: aContent->IsHTMLElement(), at /builds/worker/checkouts/gecko/docshell/base/nsDocShell.cpp:13029

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/704407d7ca31
Add support for <form rel>. r=smaug

Comment 10

[Atila Butkovits]

Backed out for causing wpt failures at put-forwards.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/5a8c175045f06829a94462823ac5da6a791c0f31

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=704407d7ca3131849cbc1b3febf982a859bc4b55&selectedTaskRun=DxrbIN8UQFOFOn1FU8ewDQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=402664304&repo=autoland&lineNumber=40204

Comment 11

[Adam Vandolder [:avandolder]]

Ah, I missed that test. Hopefully I have them all now.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dac66f1d8342
Add support for <form rel>. r=smaug

Comment 13

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/dac66f1d8342

Comment 14

[Adam Vandolder [:avandolder]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Allows use of previously unsupported standard attribute.
[Affects Firefox for Android]: n/a
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Comment 15

[Donal Meehan [:dmeehan|PTO Sept 22-Oct 3]]

Please provide some suggested wording you would like for this note.
I'll add it to the 111 nightly notes and it will follow through to 111 beta and 111 release.

Comment 16

[Adam Vandolder [:avandolder]]

[Suggested wording]: Use of the rel attribute is now supported on form elements, allowing the specification of the relationship between the current document and the form target in a simpler, cross-browser way.

Comment 17

[Donal Meehan [:dmeehan|PTO Sept 22-Oct 3]]

Thanks, added to Nightly release notes.
Keeping the relnote? flag open to keep it on the radar for inclusion in our final release notes.