1509378 - Perma test_input_event.html | uncaught exception - ReferenceError when Gecko 65 merges to Beta on 2018-12-03

Status: VERIFIED FIXED

(Core :: DOM: Events, defect, P2)

Description

[Cosmin Sabou [:CosminS]]

[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]:

Central as Beta: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&revision=c4902419549a843d9dba6fa9b8dbfdc6563266f9&searchStr=e10s%2Cmochitest&selectedJob=213392430

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=213405092&repo=try&lineNumber=4811

This looks to be a regression from Bug 1504911. Masayuki, could you please take a look? 

18:41:56     INFO - TEST-PASS | dom/html/test/forms/test_input_event.html | input event shouldn't be dispatched if click event is cancelled 
18:41:56     INFO - Not taking screenshot here: see the one that was previously logged
18:41:56     INFO - TEST-UNEXPECTED-FAIL | dom/html/test/forms/test_input_event.html | uncaught exception - ReferenceError: event is not defined at checkIfInputIsEvent@http://mochi.test:8888/tests/dom/html/test/forms/test_input_event.html:60:5
18:41:56     INFO - @http://mochi.test:8888/tests/dom/html/test/forms/test_input_event.html:90:7
18:41:56     INFO - testUserInput2@http://mochi.test:8888/tests/dom/html/test/forms/test_input_event.html:204:9
18:41:56     INFO - 
18:41:56     INFO -     simpletestOnerror@SimpleTest/SimpleTest.js:1644:13
18:41:56     INFO -     testUserInput2@dom/html/test/forms/test_input_event.html:204:9
18:41:56     INFO - GECKO(4640) | JavaScript error: http://mochi.test:8888/tests/dom/html/test/forms/test_input_event.html, line 60: ReferenceError: event is not defined
18:41:56     INFO - TEST-PASS | dom/html/test/forms/test_input_event.html | input event should have been dispatched 
18:41:56     INFO - TEST-PASS | dom/html/test/forms/test_input_event.html | input event should not have been dispatched 
18:41:56     INFO - TEST-PASS | dom/html/test/forms/test_input_event.html | input event shouldn't be dispatched if click event is cancelled 
18:41:56     INFO - TEST-PASS | dom/html/test/forms/test_input_event.html | undefined assertion name 
18:41:56     INFO - TEST-PASS | dom/html/test/forms/test_input_event.html | input event shouldn't be dispatched on range input element for key changes that don't change its value 
18:41:56     INFO - Not taking screenshot here: see the one that was previously logged

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3322595affee819b2624852ecb67dba6337d947d

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1509378 - Make test_input_event.html refer aEvent in checkIfInputIsEvent() rather than window.event

This is an idiot mistake.  It refers window.event accidentally and it's still
disabled on Beta and Release channel.  Therefore, we should make it refer
aEvent instead.

On the other hand, it might be better to make our lint check whether test
refers window.event directly or not because it may check odd result
accidentally.

Comment 3

[Intermittent Failures Robot]

9 failures in 2387 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* try: 9

Platform breakdown:
* linux64: 1
* windows7-32: 1
* linux32: 1
* linux64-nightly: 1
* macosx64-devedition: 1
* windows10-64: 2
* windows7-32-devedition: 1
* linux64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1509378&startday=2018-11-19&endday=2018-11-25&tree=all

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1df9d08586c5
Make test_input_event.html refer aEvent in checkIfInputIsEvent() rather than window.event r=smaug

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1df9d08586c5

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1509378 - Make test_input_number_mouse_events.html refer evt in checkInputEvent() rather than window.event

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Reopening because test_input_number_mouse_events.html still needs to be fixed.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c72e35255c5
Make test_input_number_mouse_events.html refer evt in checkInputEvent() rather than window.event r=smaug

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8c72e35255c5

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed when applied in yesterday's beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=6fcd680fa767daf2ab5706c1124a5cba3e8564e5