1509388 - Build download-subview-toolbarbutton markup directly using JS

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, task, P1)

Description

[Tim Nguyen :ntim]

The markup [0] seems small enough that it could be constructed directly in its only(?) [1] use site.


[0]: https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/browser/components/downloads/content/download.xml#15

[1]: https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/browser/components/downloads/DownloadsSubview.jsm#371

Comment 1

[:Paolo Amadini]

If I remember correctly, the problem with this binding is extends="#button-base", which currently bypasses display="xul:button" from the "toolbarbutton" binding. Restoring the button CSS frame causes issues with the hover state on the inner action button.

In fact, we may have to solve this bug before we force a button frame on all "toolbarbutton" elements for bug 1450652. It may be that we have to use a different tag.

Comment 2

[:Paolo Amadini]

Attachment: Bug 1509388 - Part 1 - Don't use a toolbarbutton element for the download-subview-toolbarbutton binding. r=Gijs

Download items in the Downloads Subview of the Library Panel are implemented using a XBL binding that is associated to a "toolbarbutton" element, but inherits from "button-base" in order to avoid the display="xul:button" of the "toolbarbutton" binding. This is because the item contains an inner button, and using a button CSS frame for the outer element would break hover behavior and mouse events.

This changes the binding so it doesn't use a "toolbarbutton" element, which is a different way to avoid the outer button CSS frame, and eventually allows removing support for the "display" attribute in XBL.

Comment 3

[:Paolo Amadini]

Attachment: Bug 1509388 - Part 2 - Build download-subview-toolbarbutton markup directly using JS. r=mak

This makes this derived class of DownloadElementShell more similar to DownloadsViewItem, and removes batch fagment handling because proper XBL construction requires elements to be connected to the document before they are accessed from JavaScript.

Depends on D14572

Comment 4

[:Paolo Amadini]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc8f085511016531bc04dbe01d8d8e0d28dc5b47

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe181f5f1a96
Part 1 - Don't use a toolbarbutton element for the download-subview-toolbarbutton binding. r=Gijs
https://hg.mozilla.org/integration/mozilla-inbound/rev/60ca811184a3
Part 2 - Build download-subview-toolbarbutton markup directly using JS. r=mak

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/fe181f5f1a96
https://hg.mozilla.org/mozilla-central/rev/60ca811184a3