Closed Bug 1509419 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 14193 - ReadableStream: modify tests for pipeThrough() having a brand check

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 14193 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/14193 Details from upstream follow. Adam Rice <ricea@chromium.org> wrote: > ReadableStream: modify tests for pipeThrough() having a brand check > > Remove tests that ReadableStream.prototype.pipeThrough operates > generically on its arguments. Add tests that it performs brand checks on > |this|, |readable| and |writable|, and throws for other precondition > failures. > > Also verify that it *doesn't* call pipeTo(). > > Also verify that preventClose, preventCancel and preventAbort work, > since we can no longer test that it passes through to pipeTo(). > > Also change the expected length of the function from 2 to 1 to reflect > that the options argument is optional.
Component: web-platform-tests → DOM
Product: Testing → Core
PR 14193 applied with additional changes from upstream: a89730a0f3638d709ccc42064c8f8eb8935b04f7
Ran 8 tests and 152 subtests OK : 4 PASS : 140 FAIL : 12 New tests that have failures or other problems: /streams/piping/pipe-through.any.html: SKIP /streams/piping/pipe-through.any.serviceworker.html: SKIP /streams/piping/pipe-through.any.sharedworker.html: SKIP /streams/piping/pipe-through.any.worker.html: SKIP /streams/readable-streams/general.any.html ReadableStream constructor will not tolerate initial garbage as cancel argument: FAIL ReadableStream constructor will not tolerate initial garbage as pull argument: FAIL ReadableStream instances should have the correct list of properties: FAIL /streams/readable-streams/general.any.serviceworker.html ReadableStream constructor will not tolerate initial garbage as cancel argument: FAIL ReadableStream constructor will not tolerate initial garbage as pull argument: FAIL ReadableStream instances should have the correct list of properties: FAIL /streams/readable-streams/general.any.sharedworker.html ReadableStream constructor will not tolerate initial garbage as cancel argument: FAIL ReadableStream constructor will not tolerate initial garbage as pull argument: FAIL ReadableStream instances should have the correct list of properties: FAIL /streams/readable-streams/general.any.worker.html ReadableStream constructor will not tolerate initial garbage as cancel argument: FAIL ReadableStream constructor will not tolerate initial garbage as pull argument: FAIL ReadableStream instances should have the correct list of properties: FAIL
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fcc10971a6e8 [wpt PR 14193] - ReadableStream: modify tests for pipeThrough() having a brand check, a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/e1782a85a325 [wpt PR 14193] - ReadableStream: modify tests for pipeThrough() having a brand check, a=testonly
https://hg.mozilla.org/mozilla-central/rev/e1782a85a325
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.