Closed Bug 1509438 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 14196 - [css-contain] Fix baseline for flex/grid items with contain: layout

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 14196 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14196
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:
>  [css-contain] Fix baseline for flex/grid items with contain: layout
>  
>  Layout containment elements are treated as having no baseline,
>  when that's applied to flex/grid items that are baseline aligned
>  that means that they should use their synthesized baseline.
>  
>  The patch is a simple check in LayoutBlockFlow::FirstLineBoxBaseline()
>  similar to what we have in other methods. If the element has
>  layout containment it has no baseline (it returns -1).
>  
>  BUG=907709
>  TEST=external/wpt/css/css-contain/contain-layout-baseline-002.html
>  TEST=external/wpt/css/css-contain/contain-layout-baseline-003.html
>  
>  Change-Id: Id393787dd24bf3e34aaf73476e446fb9d0a4e593
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1348892
>  WPT-Export-Revision: c243a70ec66ecabd9ac88750c2fae0d2e648376b
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 5 tests
PASS   : 4
FAIL   : 1

New tests that have failures or other problems:
/css/css-contain/contain-layout-baseline-004.html: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35ab42d3626e
[wpt PR 14196] - [css-contain] Fix baseline for elements with contain: layout, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/39dc1e17f388
[wpt PR 14196] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6dfbc086df47
[wpt PR 14196] - [css-contain] Fix baseline for elements with contain: layout, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/65978e67a8e7
[wpt PR 14196] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/6dfbc086df47
https://hg.mozilla.org/mozilla-central/rev/65978e67a8e7
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.