Closed
Bug 1509438
Opened 2 years ago
Closed 2 years ago
[wpt-sync] Sync PR 14196 - [css-contain] Fix baseline for flex/grid items with contain: layout
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 14196 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/14196 Details from upstream follow. Manuel Rego Casasnovas <rego@igalia.com> wrote: > [css-contain] Fix baseline for flex/grid items with contain: layout > > Layout containment elements are treated as having no baseline, > when that's applied to flex/grid items that are baseline aligned > that means that they should use their synthesized baseline. > > The patch is a simple check in LayoutBlockFlow::FirstLineBoxBaseline() > similar to what we have in other methods. If the element has > layout containment it has no baseline (it returns -1). > > BUG=907709 > TEST=external/wpt/css/css-contain/contain-layout-baseline-002.html > TEST=external/wpt/css/css-contain/contain-layout-baseline-003.html > > Change-Id: Id393787dd24bf3e34aaf73476e446fb9d0a4e593 > > Reviewed-on: https://chromium-review.googlesource.com/1348892 > WPT-Export-Revision: c243a70ec66ecabd9ac88750c2fae0d2e648376b
Assignee | ||
Updated•2 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Assignee | ||
Comment 1•2 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=46e89286374791d9355ce627cac275f3075dc71b
Assignee | ||
Comment 2•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a14fb3764c5626bf95ed0ebd079da942f3993cd4
Assignee | ||
Comment 3•2 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=b4dd42d5891ea11f5ac296bc16ec703790f65b42
Assignee | ||
Comment 4•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=dade9732deec05c0d529206aaaaead2fc741c59b
Assignee | ||
Comment 5•2 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9619a8ccc029d6ba9de97000299cb9211afc0b8
Assignee | ||
Comment 6•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=80b71d1a3bff1ae337b2f0a295f2da1401fb5304
Assignee | ||
Comment 7•2 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e795a82fbdf12cfd661f5db4fab52d1d8e5937a
Assignee | ||
Comment 8•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6ef7f6410fb0039dbb26d8ff8d4dd66707bcea3
Assignee | ||
Comment 9•2 years ago
|
||
Ran 5 tests PASS : 4 FAIL : 1 New tests that have failures or other problems: /css/css-contain/contain-layout-baseline-004.html: FAIL
Comment 10•2 years ago
|
||
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/35ab42d3626e [wpt PR 14196] - [css-contain] Fix baseline for elements with contain: layout, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/39dc1e17f388 [wpt PR 14196] - Update wpt metadata, a=testonly
Comment 11•2 years ago
|
||
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/6dfbc086df47 [wpt PR 14196] - [css-contain] Fix baseline for elements with contain: layout, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/65978e67a8e7 [wpt PR 14196] - Update wpt metadata, a=testonly
Comment 12•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6dfbc086df47 https://hg.mozilla.org/mozilla-central/rev/65978e67a8e7
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•