1509440 - Home/End button should dismiss the completion text if the popup is hidden

Status: VERIFIED FIXED

(DevTools :: Console, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

**Steps to reproduce**
1. Go to `data:text/html,<meta charset=utf8>`
2. Open the console
3. Type `Wind`
4. You should now see the completion text `ow` at the end
5. Hit <kbd>Home</kbd>
6. Hit <kbd>ArrowRight</kbd>

**Expected results**

The input still contains `Wind` and the cursor is after the `W`

**Actual results**

At 5. the completion node is not dismissed, and then, when hitting arrow right, the input gets weirdly completed with it, making the input `owWind`

---

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1509440 - Fix JsTerm completionText handling with Left/Home/End keys; r=Honza.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

TRY looks good https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f089aed1fc01f9877d3a4964183bbd74008761f

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/614d2236358a
Fix JsTerm completionText handling with Left/Home/End keys; r=Honza.

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/614d2236358a

Comment 5

[Daniel Cicas [:dcicas], Release QA]

I reproduced this issue using Fx 65.0a1, build ID: 20181122220059, on Windows 10 x64.

I can confirm this issue is fixed, I verified using Fx 65.0b12, build ID: 20190117232427, on Windows 10 x64, macOS X 10.13 and Ubuntu 18.04.