Closed
Bug 1509481
Opened 7 years ago
Closed 7 years ago
[wpt-sync] Sync PR 14203 - Revert "[EventTiming] Move tests to WPT"
Categories
(Testing :: web-platform-tests, enhancement, P4)
Testing
web-platform-tests
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 14203 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/14203
Details from upstream follow.
Findit <findit-for-me@appspot.gserviceaccount.com> wrote:
> Revert "[EventTiming] Move tests to WPT"
>
> This reverts commit f1fb6d618beab1830a086c43acee5c3c1c8d8028.
>
> Reason for revert:
>
> Findit (https://goo.gl/kROfz5) identified CL at revision 610504 as the
> culprit for flakes in the build cycles as shown on:
> https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjFmYjZkNjE4YmVhYjE4MzBhMDg2YzQzYWNlZTVjM2MxYzhkODAyOAw
>
> Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/6917
>
> Sample Failed Step: webkit_layout_tests on Intel GPU on Mac on Mac-10.12.6
>
> Sample Flaky Test: external/wpt/event-timing/event-timing-timingconditions.html
>
> Original change's description:
> > [EventTiming] Move tests to WPT
> >
> > This CL moves Event Timing tests to web-platform-tests. Relevant changes:
> > * Move to using test_driver.click.
> > * Replace setTimeout with step_timeout.
> > * Move to using a python-based slow image resource.
> >
> > Bug: 841224
> > Change-Id: I21f322546815d7d6bcec4dd1703de50a9296d992
> > Reviewed-on: https://chromium-review.googlesource.com/c/1348855
> > Commit-Queue: Nicolás Peña Moreno \<npm@chromium.org>
> > Reviewed-by: Timothy Dresser \<tdresser@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#610504}
>
> Change-Id: Id18988562dc34b1686497c689605b8436760a10c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 841224, 907949
> Reviewed-on: https://chromium-review.googlesource.com/c/1348732
> Cr-Commit-Position: refs/heads/master@{#610512}
>
Assignee | ||
Comment 1•7 years ago
|
||
PR 14203 applied with additional changes from upstream: b9b7d2fe5ff6c06279e321c1a3e70ff61ddafa96
Assignee | ||
Comment 2•7 years ago
|
||
Assignee | ||
Comment 3•7 years ago
|
||
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d31b1d91a876
[wpt PR 14203] - Revert "[EventTiming] Move tests to WPT", a=testonly
Assignee | ||
Comment 5•7 years ago
|
||
Result changes from PR not available.
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2673d53bae9f
[wpt PR 14203] - Revert "[EventTiming] Move tests to WPT", a=testonly
Comment 7•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•