Closed Bug 1509533 Opened 4 years ago Closed 4 years ago
Shutdown profiles should include content process profiles
47 bytes, text/x-phabricator-request
|Details | Review|
Currently shutdown profiles dumped using the MOZ_PROFILER_SHUTDOWN environment variable contain only a profile of the parent process. It's likely that the other profiles are available but not written to the JSON file we dump to the disk. More info from Markus: > here’s the code that doesn’t include content process profiles: > https://searchfox.org/mozilla-central/rev/20df68a5f5b5e078a11fa62a681f09debda61d79/tools/profiler/core/platform.cpp#3012-3015 > > `nsProfiler::mExitProfiles` probably has the content process profiles; > in the normal profile collection code paths we include those: > https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/tools/profiler/gecko/nsProfiler.cpp#648-657
Tentatively setting as P1, since folks are actively looking at startup/shutdown right now, and this is a blocker.
Priority: -- → P1
Assignee: nobody → gsquelart
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/169e737928ca Include child process profiles in shutdown profiles - r=mstange
You need to log in before you can comment on or make changes to this bug.