Reenable the start time assertion in StreamTracks.h

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P2
normal
Rank:
15
RESOLVED FIXED
6 months ago
4 months ago

People

(Reporter: padenot, Assigned: pehrsons)

Tracking

Trunk
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(6 attachments, 1 obsolete attachment)

Reporter

Description

6 months ago
Disable to keep the Stream -> Tracks refactoring in the tree, but we should have a look.

Comment 2

6 months ago
Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a95519247ae7
Temporarily disable an assertion following 1423241.
Reporter

Comment 3

6 months ago
Andreas, if you could have a look in a timely manner it would be great, thanks!
Blocks: 1423241
Flags: needinfo?(apehrson)

Comment 4

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a95519247ae7
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Reporter

Comment 5

6 months ago
Oops I meant to mark this one leave-open.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee

Updated

6 months ago
Status: REOPENED → ASSIGNED
Flags: needinfo?(apehrson)
Assignee

Comment 6

6 months ago
Since DecodedStream pushes data ahead of the MediaStreamGraph's currentTime we have some data buffered in StreamTracks.

When seeking, the original media element stops playback and starts seeking. The captureStream will continue to play the buffered data instead (breaking spec).

When seeking is finished the original media element starts playback again, from the new position. DecodedStream on the other hand creates new tracks for playing from the new position (breaking spec). If the old tracks haven't ended yet, there's an overlap in the stream's timeline, and the new tracks are added to the graph *before* the knownTracksTime (which is the end of the pushed data) and we fail the assert.

This ties a bit into bug 1172394 since we should not create new tracks when seeking. Fixing that should be the long-term solution for this bug.

Short-term I feel inclined to remove knownTracksTime altogether. It is used as a measure outside of end times of track's to keep a stream's currentTime from advancing. With it removed, a stream's currentTime would instead be capped at the earliest end time of its non-ended tracks. That seems fine.
We'd also lose this assert, but that seems fine to me too.


Also note that of all users of SourceMediaStream, only DecodedStream is currently using AdvanceKnownTracksTime, https://searchfox.org/mozilla-central/search?q=SourceMediaStream%3A%3AAdvanceKnownTracksTime&case=false&regexp=false&path=
Assignee

Comment 11

6 months ago
Without knownTracksTime, StreamTracks::GetFirstTrackEnd() returns
STREAM_TIME_MAX for an empty StreamTracks, so PullNewData() thinks no new data
is needed.

This circumvents that by always checking whether tracks need data.
Attachment #9027576 - Attachment is obsolete: true

Updated

6 months ago
Rank: 15
Priority: -- → P2

Comment 13

6 months ago
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1d1b47e23537
Remove the concept of a known tracks time from MediaStreamGraph. r=padenot
https://hg.mozilla.org/integration/autoland/rev/8a064f0dbb2f
Rename track-end-time methods in StreamTracks. r=padenot
https://hg.mozilla.org/integration/autoland/rev/dfde7b2c53a6
Clean up what appears to be wip-leftover gunk in DecodedStream. r=jya
https://hg.mozilla.org/integration/autoland/rev/311cee86bc66
Remove early PullNewData return. r=padenot
https://hg.mozilla.org/integration/autoland/rev/daaecb62f373
Make MediaStreamGraph pull data per track instead of per stream. r=padenot
Assignee

Updated

5 months ago
Depends on: 1513973
Depends on: 1521577
Assignee

Updated

4 months ago
Depends on: 1523817
You need to log in before you can comment on or make changes to this bug.