1509576 - Crash in mozilla::dom::XULTooltipElement::PostHandleEvent

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P1)

Description

[[:philipp]]

This bug was filed from the Socorro interface and is
report bp-dec99f3f-f445-4d1d-8a9d-c745a0181123.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll mozilla::dom::XULTooltipElement::PostHandleEvent dom/xul/XULTooltipElement.cpp:93
1 xul.dll static void mozilla::EventTargetChainItem::HandleEventTargetChain dom/events/EventDispatcher.cpp:644
2 xul.dll static void mozilla::EventTargetChainItem::HandleEventTargetChain dom/events/EventDispatcher.cpp:721
3 xul.dll mozilla::EventDispatcher::Dispatch dom/events/EventDispatcher.cpp:1156
4 xul.dll void nsXULPopupManager::FirePopupShowingEvent layout/xul/nsXULPopupManager.cpp:1458
5 xul.dll void nsXULPopupManager::ShowTooltipAtScreen layout/xul/nsXULPopupManager.cpp:847
6 xul.dll void nsXULTooltipListener::LaunchTooltip layout/xul/nsXULTooltipListener.cpp:532
7 xul.dll nsresult nsXULTooltipListener::ShowTooltip layout/xul/nsXULTooltipListener.cpp:426
8 xul.dll static void nsXULTooltipListener::sTooltipCallback layout/xul/nsXULTooltipListener.cpp:742
9 xul.dll nsTimerImpl::Fire xpcom/threads/nsTimerImpl.cpp:684

=============================================================

this crash signature is newly showing up in firefox 64, perhaps related to the work in bug 1461798?

Comment 1

[Brendan Dahl [:bdahl]]

Attachment: Bug 1509576 - Fix crash when showing tooltip. r=NeilDeakin

Handle the case when there is no tooltip text provider.

Comment 2

[Brendan Dahl [:bdahl]]

I'm not sure I understand how the tooltip provider can be null, but maybe this is during shutdown?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bbf691c2a7e
Fix crash when showing tooltip. r=NeilDeakin

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1bbf691c2a7e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 6

[Brendan Dahl [:bdahl]]

Comment on attachment 9027994 [details]
Bug 1509576 - Fix crash when showing tooltip. r=NeilDeakin

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1461798

User impact if declined: Firefox can crash under unknown circumstances.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Simple null ptr check added.

String changes made/needed:

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9027994 [details]
Bug 1509576 - Fix crash when showing tooltip. r=NeilDeakin

Crash fix, let's uplift for the 64 RC.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/729dc4b0b006