Closed Bug 1509609 Opened 9 months ago Closed 7 months ago

Provide a sync version of generateBundles for L10nregistry

Categories

(Core :: Internationalization, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

L10nRegistry is currently fully async which handles correctly the Fluent localization scenario.

But when we want to use Fluent for cases like mozIntl we need a sync version of the API.

The first use case will be bug 1509583.
Assignee: nobody → gandalf
Blocks: 1462839, 1509583
Priority: -- → P3
Comment on attachment 9028115 [details]
Bug 1509609 - Provide a sync version of generateBundles for L10nregistry. r?mossop

I know, I know. Nothing short of beauty. But welp. :)

The patch works - I just cloned the test suite and did `s/generateBundle/generateBundleSync/`, `s/async //` and `s/await //`.

Before I dive to document it (mostly to express that this is equivalent of sync XMLHttpRequest - do not use without getting a go-ahead from you or me), I'd like to check with you if you if this model of duplication is ok with you.

I don't love it, but it keeps the sync/async functions next to each other and shouldn't make the maintenance too much of a burden.
Attachment #9028115 - Flags: feedback?(dtownsend)
Status: NEW → ASSIGNED
Attachment #9028115 - Flags: feedback?(dtownsend) → feedback+
Attachment #9028115 - Attachment description: Bug 1509609 - Provide a sync version of generateBundles for L10nregistry. → Bug 1509609 - Provide a sync version of generateBundles for L10nregistry. r?mossop
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7d8101dcf03a
Provide a sync version of generateBundles for L10nregistry. r=mossop
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.