1509609 - Provide a sync version of generateBundles for L10nregistry

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement, P3)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

L10nRegistry is currently fully async which handles correctly the Fluent localization scenario.

But when we want to use Fluent for cases like mozIntl we need a sync version of the API.

The first use case will be bug 1509583.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1509609 - Provide a sync version of generateBundles for L10nregistry. r?mossop

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 9028115 [details]
Bug 1509609 - Provide a sync version of generateBundles for L10nregistry. r?mossop

I know, I know. Nothing short of beauty. But welp. :)

The patch works - I just cloned the test suite and did `s/generateBundle/generateBundleSync/`, `s/async //` and `s/await //`.

Before I dive to document it (mostly to express that this is equivalent of sync XMLHttpRequest - do not use without getting a go-ahead from you or me), I'd like to check with you if you if this model of duplication is ok with you.

I don't love it, but it keeps the sync/async functions next to each other and shouldn't make the maintenance too much of a burden.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d8101dcf03a
Provide a sync version of generateBundles for L10nregistry. r=mossop

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7d8101dcf03a