1509611 - [wpt-sync] Sync PR 14219 - Revert "Align resource timing buffer full processing to spec PR 168"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 14219 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14219
Details from upstream follow.

Findit <[e-mail]> wrote:
>  Revert "Align resource timing buffer full processing to spec PR 168"
>  
>  This reverts commit 579d65014c9d6cc248ec1de47013bf6c20c72158.
>  
>  Reason for revert:
>  
>  Findit (https://goo.gl/kROfz5) identified CL at revision 610667 as the
>  culprit for flakes in the build cycles as shown on:
>  https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNTc5ZDY1MDE0YzlkNmNjMjQ4ZWMxZGU0NzAxM2JmNmMyMGM3MjE1OAw
>  
>  Sample Failed Build: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/26746
>  
>  Sample Failed Step: webkit_layout_tests
>  
>  Sample Flaky Test: external/wpt/resource-timing/buffer-full-store-and-clear-during-callback.html
>  
>  Original change's description:
>  > Align resource timing buffer full processing to spec PR 168
>  > 
>  > This change implements the processing model from PR 168[1], when
>  > it comes to setResourceTimingBufferSize(), clearResourceTimings()
>  > and the firing of the resourcetimingbufferfull event.
>  > 
>  > [1] https://github.com/w3c/resource-timing/pull/168
>  > 
>  > Change-Id: I3a57196f10e0b4cf2bae5662b0e075673a0c2d80
>  > Reviewed-on: https://chromium-review.googlesource.com/c/1345269
>  > Commit-Queue: Yoav Weiss \<[e-mail]>
>  > Commit-Queue: Yoav Weiss \<[e-mail]>
>  > Reviewed-by: Nicolás Peña Moreno \<[e-mail]>
>  > Cr-Commit-Position: refs/heads/master@{#610667}
>  
>  Change-Id: I0840bd9b763030b6e200e8f9a94c73c7982044a0
>  No-Presubmit: true
>  No-Tree-Checks: true
>  No-Try: true
>  Bug: 908181
>  Reviewed-on: https://chromium-review.googlesource.com/c/1349498
>  Cr-Commit-Position: refs/heads/master@{#610683}
>

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 14219 applied with additional changes from upstream: 06720fac129ee8916f1a9309ebc0bfa134604bfe

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=52b1aadad21abda51292a530cd85479fa83cfa99

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb927a5afb03c844c77e034696925d264f9a865d

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 3 tests and 14 subtests
OK     : 3
PASS   : 5
FAIL   : 9

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d0334e10ba1
[wpt PR 14219] - Revert "Align resource timing buffer full processing to spec PR 168", a=testonly

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b2b6bddba0b
[wpt PR 14219] - Revert "Align resource timing buffer full processing to spec PR 168", a=testonly

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/5b2b6bddba0b