[wpt-sync] Sync PR 14219 - Revert "Align resource timing buffer full processing to spec PR 168"

RESOLVED FIXED in Firefox 66

Status

()

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement
Importance:
P4
normal
Status:
RESOLVED FIXED
Reported:
6 months ago
Modified:
2 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

Version:
unspecified
Target:
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: [wptsync downstream],
URL
)

Assignee

Description

•
6 months ago 
Sync web-platform-tests PR 14219 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14219
Details from upstream follow.

Findit <findit-for-me@appspot.gserviceaccount.com> wrote:
>  Revert "Align resource timing buffer full processing to spec PR 168"
>  
>  This reverts commit 579d65014c9d6cc248ec1de47013bf6c20c72158.
>  
>  Reason for revert:
>  
>  Findit (https://goo.gl/kROfz5) identified CL at revision 610667 as the
>  culprit for flakes in the build cycles as shown on:
>  https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNTc5ZDY1MDE0YzlkNmNjMjQ4ZWMxZGU0NzAxM2JmNmMyMGM3MjE1OAw
>  
>  Sample Failed Build: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/26746
>  
>  Sample Failed Step: webkit_layout_tests
>  
>  Sample Flaky Test: external/wpt/resource-timing/buffer-full-store-and-clear-during-callback.html
>  
>  Original change's description:
>  > Align resource timing buffer full processing to spec PR 168
>  > 
>  > This change implements the processing model from PR 168[1], when
>  > it comes to setResourceTimingBufferSize(), clearResourceTimings()
>  > and the firing of the resourcetimingbufferfull event.
>  > 
>  > [1] https://github.com/w3c/resource-timing/pull/168
>  > 
>  > Change-Id: I3a57196f10e0b4cf2bae5662b0e075673a0c2d80
>  > Reviewed-on: https://chromium-review.googlesource.com/c/1345269
>  > Commit-Queue: Yoav Weiss \<yoavweiss@chromium.org>
>  > Commit-Queue: Yoav Weiss \<yoav@yoav.ws>
>  > Reviewed-by: Nicolás Peña Moreno \<npm@chromium.org>
>  > Cr-Commit-Position: refs/heads/master@{#610667}
>  
>  Change-Id: I0840bd9b763030b6e200e8f9a94c73c7982044a0
>  No-Presubmit: true
>  No-Tree-Checks: true
>  No-Try: true
>  Bug: 908181
>  Reviewed-on: https://chromium-review.googlesource.com/c/1349498
>  Cr-Commit-Position: refs/heads/master@{#610683}
>
Assignee

Comment 1

•
6 months ago 
PR 14219 applied with additional changes from upstream: 06720fac129ee8916f1a9309ebc0bfa134604bfe
 Assignee

Updated

•
6 months ago
Component: web-platform-tests → DOM
Product: Testing → Core
 Assignee

Comment 4

•
6 months ago 
Ran 3 tests and 14 subtests
OK     : 3
PASS   : 5
FAIL   : 9

Comment 5

•
5 months ago 
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d0334e10ba1
[wpt PR 14219] - Revert "Align resource timing buffer full processing to spec PR 168", a=testonly

Comment 6

•
5 months ago 
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b2b6bddba0b
[wpt PR 14219] - Revert "Align resource timing buffer full processing to spec PR 168", a=testonly

Comment 7

•
5 months ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/5b2b6bddba0b
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.