Closed
Bug 1509611
Opened 7 years ago
Closed 7 years ago
[wpt-sync] Sync PR 14219 - Revert "Align resource timing buffer full processing to spec PR 168"
Categories
(Core :: DOM: Core & HTML, enhancement, P4)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 14219 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/14219
Details from upstream follow.
Findit <findit-for-me@appspot.gserviceaccount.com> wrote:
> Revert "Align resource timing buffer full processing to spec PR 168"
>
> This reverts commit 579d65014c9d6cc248ec1de47013bf6c20c72158.
>
> Reason for revert:
>
> Findit (https://goo.gl/kROfz5) identified CL at revision 610667 as the
> culprit for flakes in the build cycles as shown on:
> https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNTc5ZDY1MDE0YzlkNmNjMjQ4ZWMxZGU0NzAxM2JmNmMyMGM3MjE1OAw
>
> Sample Failed Build: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/26746
>
> Sample Failed Step: webkit_layout_tests
>
> Sample Flaky Test: external/wpt/resource-timing/buffer-full-store-and-clear-during-callback.html
>
> Original change's description:
> > Align resource timing buffer full processing to spec PR 168
> >
> > This change implements the processing model from PR 168[1], when
> > it comes to setResourceTimingBufferSize(), clearResourceTimings()
> > and the firing of the resourcetimingbufferfull event.
> >
> > [1] https://github.com/w3c/resource-timing/pull/168
> >
> > Change-Id: I3a57196f10e0b4cf2bae5662b0e075673a0c2d80
> > Reviewed-on: https://chromium-review.googlesource.com/c/1345269
> > Commit-Queue: Yoav Weiss \<yoavweiss@chromium.org>
> > Commit-Queue: Yoav Weiss \<yoav@yoav.ws>
> > Reviewed-by: Nicolás Peña Moreno \<npm@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#610667}
>
> Change-Id: I0840bd9b763030b6e200e8f9a94c73c7982044a0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 908181
> Reviewed-on: https://chromium-review.googlesource.com/c/1349498
> Cr-Commit-Position: refs/heads/master@{#610683}
>
Assignee | ||
Comment 1•7 years ago
|
||
PR 14219 applied with additional changes from upstream: 06720fac129ee8916f1a9309ebc0bfa134604bfe
Assignee | ||
Updated•7 years ago
|
Component: web-platform-tests → DOM
Product: Testing → Core
Assignee | ||
Comment 2•7 years ago
|
||
Assignee | ||
Comment 3•7 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb927a5afb03c844c77e034696925d264f9a865d
Assignee | ||
Comment 4•7 years ago
|
||
Ran 3 tests and 14 subtests
OK : 3
PASS : 5
FAIL : 9
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d0334e10ba1
[wpt PR 14219] - Revert "Align resource timing buffer full processing to spec PR 168", a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b2b6bddba0b
[wpt PR 14219] - Revert "Align resource timing buffer full processing to spec PR 168", a=testonly
Comment 7•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•