1509634 - Remove toolkit/themes/osx/mozapps/extensions/toolbarbutton-dropmarker.png and replace usage with arrow-dropdown-12.svg

Status: RESOLVED FIXED

(Toolkit :: Themes, enhancement, P3)

Description

[Tim Nguyen :ntim]

Steps to solve this bug:
1) At https://searchfox.org/mozilla-central/rev/20df68a5f5b5e078a11fa62a681f09debda61d79/toolkit/themes/osx/mozapps/extensions/extensions.css#22 , replace the url to be "chrome://global/skin/icons/arrow-dropdown-12.svg"

2) Remove this line: https://searchfox.org/mozilla-central/rev/20df68a5f5b5e078a11fa62a681f09debda61d79/toolkit/themes/osx/mozapps/jar.mn#13

3) Remove this file:
toolkit/themes/osx/mozapps/extensions/toolbarbutton-dropmarker.png

Comment 1

[quinn.daneyko]

Hi Tim, can I take this on as my first bug? I've already cloned the repo. 

Thanks

Comment 2

[Tim Nguyen :ntim]

(In reply to quinn.daneyko from comment #1)
> Hi Tim, can I take this on as my first bug? I've already cloned the repo. 
> 
> Thanks

Sure, please let me know if you have any questions!

Comment 3

[quinn.daneyko]

Hi Tim, 

I've got the patch commited locally, but not sure how to push, and just kinda overwhelmed with all the info out there. Is there a preferred doc. I can follow to go through the process? Is a phabricator account needed?

Thanks a bunch

Comment 4

[Tim Nguyen :ntim]

(In reply to quinn.daneyko from comment #3)
> Hi Tim, 
> 
> I've got the patch commited locally, but not sure how to push, and just
> kinda overwhelmed with all the info out there. Is there a preferred doc. I
> can follow to go through the process? Is a phabricator account needed?
> 
> Thanks a bunch

You can follow everything up until “Submitting patches” on this page: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html to submit a patch using Phabricator. Once you have moz-phab installed and the changes committed, you can do ‘moz-phab submit’.

Please let me know if you have any trouble with this.

Comment 5

[quinn.daneyko]

Just a note for transparency: ran into an issue trying to use mercurial extensions to clean up my commit, then lost my laptop charger, so the laptop's out of commission for a couple of days, but will have the change pushed by next week (Dec. 6th) at the latest.

Comment 6

[Tim Nguyen :ntim]

That's totally fine, thanks for the update!

Comment 7

[quinn.daneyko]

Hey Tim, Know this is a pretty simple fix, but just ran into some technical issues that I'm not going to be able to get into for a while. Would suggest un-assigning so someone else can pick up.

Comment 8

[Tim Nguyen :ntim]

No worries, thanks for letting me know!

Comment 9

[Irvin Ives Lau]

Attachment: patch.diff

Hi Tim, thank you for referring me to this bug.

I have attached a patch to this bug please kindly review it. 

Thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/008fb8183cac
Remove toolkit/themes/osx/mozapps/extensions/toolbarbutton-dropmarker.png and replace usage with arrow-dropdown-12.svg. r=jaws

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/008fb8183cac