Remove toolkit/themes/osx/mozapps/extensions/toolbarbutton-dropmarker.png and replace usage with arrow-dropdown-12.svg

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: ntim, Assigned: lauirvin98, Mentored)

Tracking

(Blocks 1 bug, {good-first-bug})

unspecified
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 months ago
Steps to solve this bug:
1) At https://searchfox.org/mozilla-central/rev/20df68a5f5b5e078a11fa62a681f09debda61d79/toolkit/themes/osx/mozapps/extensions/extensions.css#22 , replace the url to be "chrome://global/skin/icons/arrow-dropdown-12.svg"

2) Remove this line: https://searchfox.org/mozilla-central/rev/20df68a5f5b5e078a11fa62a681f09debda61d79/toolkit/themes/osx/mozapps/jar.mn#13

3) Remove this file:
toolkit/themes/osx/mozapps/extensions/toolbarbutton-dropmarker.png

Comment 1

5 months ago
Hi Tim, can I take this on as my first bug? I've already cloned the repo. 

Thanks
Flags: needinfo?(ntim.bugs)
(Reporter)

Comment 2

5 months ago
(In reply to quinn.daneyko from comment #1)
> Hi Tim, can I take this on as my first bug? I've already cloned the repo. 
> 
> Thanks

Sure, please let me know if you have any questions!
Assignee: nobody → quinn.daneyko
Flags: needinfo?(ntim.bugs)

Comment 3

5 months ago
Hi Tim, 

I've got the patch commited locally, but not sure how to push, and just kinda overwhelmed with all the info out there. Is there a preferred doc. I can follow to go through the process? Is a phabricator account needed?

Thanks a bunch
Flags: needinfo?(ntim.bugs)
(Reporter)

Comment 4

5 months ago
(In reply to quinn.daneyko from comment #3)
> Hi Tim, 
> 
> I've got the patch commited locally, but not sure how to push, and just
> kinda overwhelmed with all the info out there. Is there a preferred doc. I
> can follow to go through the process? Is a phabricator account needed?
> 
> Thanks a bunch

You can follow everything up until “Submitting patches” on this page: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html to submit a patch using Phabricator. Once you have moz-phab installed and the changes committed, you can do ‘moz-phab submit’.

Please let me know if you have any trouble with this.
Flags: needinfo?(ntim.bugs)

Comment 5

5 months ago
Just a note for transparency: ran into an issue trying to use mercurial extensions to clean up my commit, then lost my laptop charger, so the laptop's out of commission for a couple of days, but will have the change pushed by next week (Dec. 6th) at the latest.
(Reporter)

Comment 6

5 months ago
That's totally fine, thanks for the update!
Priority: -- → P3

Comment 7

4 months ago
Hey Tim, Know this is a pretty simple fix, but just ran into some technical issues that I'm not going to be able to get into for a while. Would suggest un-assigning so someone else can pick up.
Flags: needinfo?(ntim.bugs)
(Reporter)

Comment 8

4 months ago
No worries, thanks for letting me know!
Assignee: quinn.daneyko → nobody
Flags: needinfo?(ntim.bugs)
(Assignee)

Comment 9

4 months ago
Posted patch patch.diffSplinter Review
Hi Tim, thank you for referring me to this bug.

I have attached a patch to this bug please kindly review it. 

Thanks!
Attachment #9030914 - Flags: review?(ntim.bugs)
Assignee: nobody → lauirvin98
Mentor: ntim.bugs
Status: NEW → ASSIGNED
Attachment #9030914 - Flags: review?(ntim.bugs) → review+

Comment 10

4 months ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/008fb8183cac
Remove toolkit/themes/osx/mozapps/extensions/toolbarbutton-dropmarker.png and replace usage with arrow-dropdown-12.svg. r=jaws
https://hg.mozilla.org/mozilla-central/rev/008fb8183cac
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.