1509656 - Clicking on the pinned "super comments" on a live chat in a youtube livestream uses 2.2 GB RAM. Most of it is gpu-committed and gpu-shared (non-WR)

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect, P3)

Description

[Mayank Bansal]

Attachment: memory-report.json.gz

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

i was watching a live stream with the chat window on youtube : https://www.youtube.com/watch?v=jfZ61lC89Vc

scroll the chat window up and down a few times


Actual results:

ram increases very fast. It reached 2.2GB in my case
If I hide the chat window, memory use decreases


Expected results:

not so

Comment 1

[Mayank Bansal]

i tried to repro on another livestream with comments, but didnt reproduce.
In the original livestream, there were lots of "supe comments". Maybe the chat stream needs some "supe commnets" to repro the memory use?

Comment 2

[Andre Klapper]

What are "supe comments"?

Comment 3

[Mayank Bansal]

I meant "'super comments".
 These are the comments where you donate money to the livestreamer. Depending on the amount you donate, the comment gets "pinned" at the top of the chat window for some time. 
In my original livestream, there were a lot of "super comments". 

I think the best way to get a livestream with lots of "super comments" would be to go to https://www.youtube.com/channel/UC4R8DWoMoI7CAwX8_LjQHig , and then try a few streams to check

Comment 4

[Mayank Bansal]

OK. HEre is the STR:
You dont even need to sign in to youtube.

1. Go to https://www.youtube.com/watch?v=jfZ61lC89Vc&t=15s
1.5  Make sure that the chat mode is "top comments"
2. go to roughly the 31-32 minute mark. This is the time when the donations start pouring in
3. When a donation comes it gets pinned at teh top. 
4. Click on the pinned comment. This will show a popup with the money amount, name of the commentor, and the comment.

When a pinned comment is clicked, memory increases very quickly. If you scroll to a time where there are a lot of pinned comments (35 minute mark), and click on a pinned comment, wait for a few seconds, and hen click on another. 
This will cause the memory to grow.

Comment 5

[Mayank Bansal]

Attachment: memory-report.json.gz

On a fresh profile, without looging in to google/youtube.
memory use was around 2GB.

Comment 6

[Mayank Bansal]

Attachment: bandicam 2018-11-25 06-01-55-535.mp4

video of what to do. Slight change is to wait for a few seconds when you click on a pinned comment

Comment 7

[Mayank Bansal]

Attachment: low_mem.json.gz

before I open the chat window

Comment 8

[Mayank Bansal]

Attachment: high_mem.json.gz

after I open the chat window, and click on a few pinned comments

Comment 9

[Mayank Bansal]

Attachment: obsoleted

Comment 10

[Mayank Bansal]

this is not related to video per se. Looks more like a gfx issue.

Comment 11

[Mayank Bansal]

if i enable WR or use skia as the backend, i dont see any memory increase

Comment 12

[Mayank Bansal]

Attachment: aboutsupport.txt

Comment 13

[Mayank Bansal]

If i disable hardware acceleration, I cant repro it. So most probably a driver/D2D issue.
Also, was able to repro this in a 1 year old, and a 2 year old build. So definitely not a recent regression

Comment 14

[Stefan [:StefanG_QA]]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0  (20181126100057)

I've tested this report on Windows 10 using the latest Nightly and Fx release builds. I did not manage to reproduce it with the steps from comment 4 and with a couple of random live streams. When loading a video with super comments I do not observe my RAM to go up.

Comment 15

[Mayank Bansal]

(In reply to Stefan [:StefanG_QA] from comment #14)
> Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101
> Firefox/65.0  (20181126100057)
> 
> I've tested this report on Windows 10 using the latest Nightly and Fx
> release builds. I did not manage to reproduce it with the steps from comment
> 4 and with a couple of random live streams. When loading a video with super
> comments I do not observe my RAM to go up.

Could be your graphics adapter and driver are different than mine.. I would be glad to share my screen or something to help you repro the STR.

Comment 16

[Andrew McCreight [:mccr8]]

Bas, any ideas? Maybe there's something we're doing that could improve this case? It seems weird that we get so much driver memory for a little YouTube feature.

Comment 17

[Mayank Bansal]

A better URL could be https://www.youtube.com/watch?v=wdBK2ac2Ihs&t=2358s
open it, let the video play, open the chatstream and click on the "super comments".

Comment 18

[Mayank Bansal]

:rhunt is probably more associated with gfx now

Comment 19

[Ryan Hunt [:rhunt] (on leave until early May)]

I don't think I will be able to get to this as this is my last week on the graphics team.

Comment 20

[Mayank Bansal]

non-WR doesnt exist anymore