1509724 - Error: mozilla-central/media/libvpx/libvpx/vpx_ports/x86_abi_support.asm:panic: assertion cv8_state.source_files != NULL failed at output/codeview.c:517 when using NASM

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jan Henning [:JanH]]

Attachment: build.log

After updating my repository from 7154eb3601f3 to c48931864919, building Firefox on Windows 7 fails:

> 12:23.29 e:/mozilla-source/mozilla-central/media/libvpx/libvpx/vpx_ports/x86_abi_support.asm:panic: assertion cv8_state.source_files != NULL failed at output/codeview.c:517
> 12:23.30 mozmake.EXE[4]: *** [e:/mozilla-source/mozilla-central/config/rules.mk:807: x86_abi_support.obj] Error 3
> 12:23.31 mozmake.EXE[3]: *** [e:/mozilla-source/mozilla-central/config/recurse.mk:74: media/libvpx/target] Error 2

Comment 1

[Jan Henning [:JanH]]

(In reply to Jan Henning [:JanH] from comment #0)
> After updating my repository from 7154eb3601f3 to c48931864919, building

That in itself wasn't the problem, but because that range contains bug 1501796, I installed NASM 2.14 and added it to Mozilla Build's shell path.

Comment 2

[Michael Shal [:mshal]]

TD-Linux: any feedback or recommendations here?

Comment 3

[Thomas Daede [:TD-Linux]]

Ah, this looks like a bug inside nasm in its WinDbg generation (codeview). I'll see if I can reproduce. In the meantime, you can work around it just by uninstalling nasm (it'll currently fall back to yasm)

Comment 4

[Thomas Daede [:TD-Linux]]

I managed to repro this on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=051aa2b84de7409a101d8f2517daa1e6be9d852d&selectedJob=222058837

Comment 5

[Thomas Daede [:TD-Linux]]

The actual issue is that x86_abi_support.asm is included as a source file, when it shouldn't be (it doesn't emit any object code)

Comment 6

[Thomas Daede [:TD-Linux]]

Attachment: Bug 1509724 - Don't include x86_abi_support.asm in libvpx build.

Comment 7

[Thomas Daede [:TD-Linux]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=89c6a6f101f643910635ec22350ce2462ff085ae

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c82dc10b75c0
Don't include x86_abi_support.asm in libvpx build. r=dmajor

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/c82dc10b75c0