1509804 - Automatic export of HAR is broken due to EventEmitter refactor from last year

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P5)

Description

[Jordan Mendelson]

Attachment: har-automation.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.0 Safari/605.1.15

Steps to reproduce:

1. Set devtools.netmonitor.har.enableAutoExportToFile = true
2. Opened dev tools
3. Browsed around


Actual results:

No har files showed up in profile directory


Expected results:

Har files should have showed up.

This appears to be due to a bug in har-automation.js. The onTabNavigated event listener is trying to check type for 'navigated' and 'will-navigate', but that is no longer passed in so HAR files are never created.

I've attached a quick patch. I haven't tested it so it may be buggy.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1509804 - Temporary fix for HAR automation

This fixes several gaps:

• event api changes
• networkEvent no longer emitted by debugger client
• shape of expected HAR items changed
• use the connector from the netmon api

This is the minimum set of changes I could do to get HAR automation to save valid HAR files again.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1509804 - Add smoke test for HAR automation

Depends on D55204

This is just a smoke test to verify that the HAR file is created.
We should probably expand this and test the content as well, but we can handle that in follow up bugs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4459904376f
Temporary fix for HAR automation r=Honza
https://hg.mozilla.org/integration/autoland/rev/76944c9ad43c
Add smoke test for HAR automation r=Honza

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a4459904376f
https://hg.mozilla.org/mozilla-central/rev/76944c9ad43c