[socket process] Stop using HTTP connection manager on the parent process

RESOLVED FIXED

Status

()

enhancement
P2
normal
RESOLVED FIXED
5 months ago
2 months ago

People

(Reporter: dragana, Assigned: kershaw)

Tracking

(Blocks 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(firefox65 affected)

Details

(Whiteboard: [necko-triaged])

Attachments

(5 attachments)

Comment hidden (empty)
(Reporter)

Updated

5 months ago
Priority: -- → P2
Whiteboard: [necko-triaged]
(Assignee)

Updated

3 months ago
Assignee: nobody → kershaw
(Assignee)

Comment 1

3 months ago

This is a short summary about things we need to do for not using http connection manager on parent process.

  1. Decouple nsHttpConnectionMgr and AltSvcCache.
    Currently, nsHttpConnectionMgr inherited from AltSvcCache [1]. A lot of code in AlternateServices.cpp access connection manager just for the methods AltSvcCache, like [2].

  2. Proxy observer events in nsHttpHandler::Observe to socket process. An example is like [3].

  3. Add a IPC message for triggering SpeculativeConnect [4].

  4. Send HttpInfo from socket process to parent process [5].

  5. Implement IPC messages for [6] and [7].

[1] https://searchfox.org/mozilla-central/rev/60c4067b1cbb0f94d7dc2d7cdfa27ed579817fee/netwerk/protocol/http/nsHttpConnectionMgr.h#50
[2] https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/netwerk/protocol/http/AlternateServices.cpp#146
[3] https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/netwerk/protocol/http/nsHttpHandler.cpp#2237-2239
[4] https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/netwerk/protocol/http/nsHttpHandler.h#294
[5] https://searchfox.org/mozilla-central/rev/9eb30227b21e0aa40d51d9f9b08bb0b113c5fadb/netwerk/protocol/http/HttpInfo.cpp#13
[6] https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/netwerk/protocol/http/nsHttpChannel.cpp#6561
[7] https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/netwerk/protocol/http/nsHttpChannel.cpp#7625

(Assignee)

Comment 2

3 months ago

Since nsHttpConnectionMgr inherits AltSvcCache only for using the methods in AltSvcCache, we should seperate nsHttpConnectionMgr and AltSvcCache.

(Assignee)

Comment 7

2 months ago

Patches are landed on larch.

Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.