1509822 - [socket process] Stop using HTTP connection manager on the parent process

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P2)

Comment 1

[Kershaw Chang [:kershaw]]

This is a short summary about things we need to do for not using http connection manager on parent process.

1. Decouple nsHttpConnectionMgr and AltSvcCache.
   Currently, nsHttpConnectionMgr inherited from AltSvcCache [1]. A lot of code in AlternateServices.cpp access connection manager just for the methods AltSvcCache, like [2].

2. Proxy observer events in nsHttpHandler::Observe to socket process. An example is like [3].

3. Add a IPC message for triggering SpeculativeConnect [4].

4. Send HttpInfo from socket process to parent process [5].

5. Implement IPC messages for [6] and [7].

[1] https://searchfox.org/mozilla-central/rev/60c4067b1cbb0f94d7dc2d7cdfa27ed579817fee/netwerk/protocol/http/nsHttpConnectionMgr.h#50
[2] https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/netwerk/protocol/http/AlternateServices.cpp#146
[3] https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/netwerk/protocol/http/nsHttpHandler.cpp#2237-2239
[4] https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/netwerk/protocol/http/nsHttpHandler.h#294
[5] https://searchfox.org/mozilla-central/rev/9eb30227b21e0aa40d51d9f9b08bb0b113c5fadb/netwerk/protocol/http/HttpInfo.cpp#13
[6] https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/netwerk/protocol/http/nsHttpChannel.cpp#6561
[7] https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/netwerk/protocol/http/nsHttpChannel.cpp#7625

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1509822 - P1: Decouple nsHttpConnectionMgr and AltSvcCache

Since nsHttpConnectionMgr inherits AltSvcCache only for using the methods in AltSvcCache, we should seperate nsHttpConnectionMgr and AltSvcCache.

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 1509822 - P2: Send observer notifications to socket process

Comment 4

[Kershaw Chang [:kershaw]]

Attachment: Bug 1509822 - P3: Get HttpData from socket process

Comment 5

[Kershaw Chang [:kershaw]]

Attachment: Bug 1509822 - P4: Send IPC message for DoShiftReloadConnectionCleanup

Comment 6

[Kershaw Chang [:kershaw]]

Attachment: Bug 1509822 - P5: Not create connection manager in parent process

Comment 7

[Kershaw Chang [:kershaw]]

Patches are landed on larch.

Comment 8

[Valentin Gosu [:valentin] (he/him)]

https://hg.mozilla.org/projects/larch/rev/390cbe443d75
https://hg.mozilla.org/projects/larch/rev/20e1b7d87c51
https://hg.mozilla.org/projects/larch/rev/71751a35592a
https://hg.mozilla.org/projects/larch/rev/f929783b28b1
https://hg.mozilla.org/projects/larch/rev/a046fec1cd3a