Closed Bug 1509846 Opened 7 years ago Closed 7 years ago

Validate functions in parallel when compiling with Cranelift

Categories

(Core :: JavaScript: WebAssembly, enhancement)

Product:
Core
Component:
JavaScript: WebAssembly
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

References

Details

Attachments

(1 file)

fix.patch
7.09 KB, patch
lth
: review+
Details | Diff | Splinter Review
While looking at bug 1509441, I saw a Cranelift #idef, showing that function validation was happening on the main thread for Cranelift. This is sub-efficient for many reasons (not parallelized work + this ends up checking the head and tail twice), plus since we have all the mechanisms to do validation on helper thread and report errors to the main threads. We should just do it on the helper threads instead (this should be a small compilation time win in baldrdash).
Attached patch fix.patch — — Splinter Review
This removes ~40 lines of code and it shaves off a few hundred milliseconds when compiling AngryBots with Baldrdash.
Assignee: nobody → bbouvier
Status: NEW → ASSIGNED
Attachment #9027520 - Flags: review?(lhansen)
Attachment #9027520 - Flags: review?(lhansen) → review+
Pushed by bbouvier@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2b4844c3f4d8 Validate in parallel when compiling with Cranelift; r=lth
https://hg.mozilla.org/mozilla-central/rev/2b4844c3f4d8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: