1509889 - Learn More links in the preferences should be sentence case ("Learn more" instead of "Learn More")

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P5)

Description

[Meridel [:meridel]]

Attachment: Learn More links in Browsing and Network Settings section of Prefs

The 'Learn More' links under the Browsing and Network Settings sections of Preferences > General should be sentence case, not title case. Sentence case is the predominant pattern in prefs for links. 

Current: Learn More

Proposed: Learn more

Comment 1

[:Gijs (he/him)]

This will involve:

- updating these Fluent entities:

https://searchfox.org/mozilla-central/rev/f2028b4c38bff2a50ed6aa1763f6dc5ee62b0cc4/browser/locales/en-US/browser/preferences/preferences.ftl#424

https://searchfox.org/mozilla-central/rev/f2028b4c38bff2a50ed6aa1763f6dc5ee62b0cc4/browser/locales/en-US/browser/preferences/preferences.ftl#432

to have new identifiers (ie suffix the id with '2') and lowercasing the "M" in the value of the entity.

- updating the places where these entities are used, ie

https://searchfox.org/mozilla-central/rev/f2028b4c38bff2a50ed6aa1763f6dc5ee62b0cc4/browser/components/preferences/in-content/main.xul#656

and

https://searchfox.org/mozilla-central/rev/f2028b4c38bff2a50ed6aa1763f6dc5ee62b0cc4/browser/components/preferences/in-content/main.xul#676

to use the new entity identifiers.

When working on this bug, please request review from :flod , and feel free to ask me questions.

Comment 2

[Francesco Lodolo [:flod]]

We don't need new IDs to change the case, updating the FTL messages just for en-US would be enough.

Comment 3

[:Gijs (he/him)]

Per comment #2,

This will involve:

- updating these Fluent entities:

https://searchfox.org/mozilla-central/rev/f2028b4c38bff2a50ed6aa1763f6dc5ee62b0cc4/browser/locales/en-US/browser/preferences/preferences.ftl#424

https://searchfox.org/mozilla-central/rev/f2028b4c38bff2a50ed6aa1763f6dc5ee62b0cc4/browser/locales/en-US/browser/preferences/preferences.ftl#432

to lowercase the 'm'. :-)

Comment 4

[haotian xiang]

Hi,I'm a newbie for fixing firefox bug.Can you assigning this bug to me.I'd like to try to fix it.

Comment 5

[:Gijs (he/him)]

(In reply to haotian xiang from comment #4)
> Hi,I'm a newbie for fixing firefox bug.Can you assigning this bug to me.I'd
> like to try to fix it.

Hi! We normally assign people's first bugs when they put up a patch. I also notice you've asked this question in a few bugs - I'd recommend picking just 1 to start with. Thank you!

Comment 6

[haotian xiang]

(In reply to :Gijs (he/him) from comment #5)
> (In reply to haotian xiang from comment #4)
> > Hi,I'm a newbie for fixing firefox bug.Can you assigning this bug to me.I'd
> > like to try to fix it.
> 
> Hi! We normally assign people's first bugs when they put up a patch. I also
> notice you've asked this question in a few bugs - I'd recommend picking just
> 1 to start with. Thank you!

Hahaha. Because I joined an open source course in my university. They told me that I need pick 3 bugs and fixing them. So I just asked this question under several bugs.

Comment 7

[haotian xiang]

(In reply to undefined from comment #undefined)
> 

I've created a patch for this bug but I'm a little bit confused how to submit it. Can you help me with it?

Comment 8

[haotian xiang]

(In reply to haotian xiang from comment #6)
> (In reply to :Gijs (he/him) from comment #5)
> > (In reply to haotian xiang from comment #4)
> > > Hi,I'm a newbie for fixing firefox bug.Can you assigning this bug to me.I'd
> > > like to try to fix it.
> > 
> > Hi! We normally assign people's first bugs when they put up a patch. I also
> > notice you've asked this question in a few bugs - I'd recommend picking just
> > 1 to start with. Thank you!
> 
> Hahaha. Because I joined an open source course in my university. They told
> me that I need pick 3 bugs and fixing them. So I just asked this question
> under several bugs.

I found a link (https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide) let me try it :D

Comment 9

[haotian xiang]

(In reply to :Gijs (he/him) from comment #5)
> (In reply to haotian xiang from comment #4)
> > Hi,I'm a newbie for fixing firefox bug.Can you assigning this bug to me.I'd
> > like to try to fix it.
> 
> Hi! We normally assign people's first bugs when they put up a patch. I also
> notice you've asked this question in a few bugs - I'd recommend picking just
> 1 to start with. Thank you!

firefox-dev@firefox-dev:~/mozilla-central$ hg log -p -r bbcdb93f82dd
changeset:   440682:bbcdb93f82dd
tag:         modifying learn more
tag:         qbase
tag:         qtip
tag:         tip
user:        haotian xiang <[e-mail]>
date:        Sat Dec 01 12:12:01 2018 +0100
summary:     [mq]: modifying learn more

diff --git a/browser/locales/en-US/browser/preferences/preferences.ftl b/browser/locales/en-US/browser/preferences/preferences.ftl
--- a/browser/locales/en-US/browser/preferences/preferences.ftl
+++ b/browser/locales/en-US/browser/preferences/preferences.ftl
@@ -418,7 +418,7 @@ network-settings-title = Network Setting
 
 network-proxy-connection-description = Configure how { -brand-short-name } connects to the internet.
 
-network-proxy-connection-learn-more = Learn More
+network-proxy-connection-learn-more = Learn more
 
 network-proxy-connection-settings =
     .label = Settings…
==================================================================

Hi, This is the patch for this bug~ Thanks~

Comment 10

[:Gijs (he/him)]

(In reply to haotian xiang from comment #8)
> (In reply to haotian xiang from comment #6)
> > (In reply to :Gijs (he/him) from comment #5)
> > > (In reply to haotian xiang from comment #4)
> > > > Hi,I'm a newbie for fixing firefox bug.Can you assigning this bug to me.I'd
> > > > like to try to fix it.
> > > 
> > > Hi! We normally assign people's first bugs when they put up a patch. I also
> > > notice you've asked this question in a few bugs - I'd recommend picking just
> > > 1 to start with. Thank you!
> > 
> > Hahaha. Because I joined an open source course in my university. They told
> > me that I need pick 3 bugs and fixing them. So I just asked this question
> > under several bugs.
> 
> I found a link
> (https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide) let me
> try it :D

Bit confused - this links to https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch which links to https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html - did you try to use phabricator ?

(In reply to haotian xiang from comment #9)
> firefox-dev@firefox-dev:~/mozilla-central$ hg log -p -r bbcdb93f82dd
> changeset:   440682:bbcdb93f82dd
> tag:         modifying learn more
> tag:         qbase
> tag:         qtip

You'll want to use `hg qfinish` to finalize the patch before submitting it. To amend it later, you can use `hg amend`.

> diff --git a/browser/locales/en-US/browser/preferences/preferences.ftl
> -network-proxy-connection-learn-more = Learn More
> +network-proxy-connection-learn-more = Learn more

This is only one of the 2 strings that need changing.

Comment 11

[haotian xiang]

Attachment: 31543748012_.pic.jpg

So, there is only one line of 'Learn More' that I can change

Comment 12

[haotian xiang]

(In reply to haotian xiang from comment #11)
> Created attachment 9029194 [details]
> 31543748012_.pic.jpg
> 
> So, there is only one line of 'Learn More' that I can change

(In reply to :Gijs (he/him) from comment #10)
> (In reply to haotian xiang from comment #8)
> > (In reply to haotian xiang from comment #6)
> > > (In reply to :Gijs (he/him) from comment #5)
> > > > (In reply to haotian xiang from comment #4)
> > > > > Hi,I'm a newbie for fixing firefox bug.Can you assigning this bug to me.I'd
> > > > > like to try to fix it.
> > > > 
> > > > Hi! We normally assign people's first bugs when they put up a patch. I also
> > > > notice you've asked this question in a few bugs - I'd recommend picking just
> > > > 1 to start with. Thank you!
> > > 
> > > Hahaha. Because I joined an open source course in my university. They told
> > > me that I need pick 3 bugs and fixing them. So I just asked this question
> > > under several bugs.
> > 
> > I found a link
> > (https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide) let me
> > try it :D
> 
> Bit confused - this links to
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> How_to_Submit_a_Patch which links to
> https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html - did you
> try to use phabricator ?
> 
> (In reply to haotian xiang from comment #9)
> > firefox-dev@firefox-dev:~/mozilla-central$ hg log -p -r bbcdb93f82dd
> > changeset:   440682:bbcdb93f82dd
> > tag:         modifying learn more
> > tag:         qbase
> > tag:         qtip
> 
> You'll want to use `hg qfinish` to finalize the patch before submitting it.
> To amend it later, you can use `hg amend`.
> 
> > diff --git a/browser/locales/en-US/browser/preferences/preferences.ftl
> > -network-proxy-connection-learn-more = Learn More
> > +network-proxy-connection-learn-more = Learn more
> 
> This is only one of the 2 strings that need changing.

After pulled the newest source code from site. And I find the UI is little bit different with what you attached in previous comment.

Comment 13

[:Gijs (he/him)]

There is also https://hg.mozilla.org/mozilla-central/file/tip/browser/locales/en-US/browser/preferences/preferences.ftl#l427 in the source code. That's still there in the latest version of mozilla-central, and I still see the checkbox in an up-to-date mac nightly. I don't know why you don't. Have you checked the DOM (use the regular developer tools to inspect the page) - is it maybe hidden for some reason?

Comment 14

[haotian xiang]

Attachment: Bug 1509889 - change "Learn More" to "Learn more" in preferences strings

Comment 15

[Francesco Lodolo [:flod]]

I've approved the patch, but in Lando I get "Repository is not supported by Lando.", which leaves me quite puzzled. Any clue?

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/65ee8bd1ce81
change 'Learn More' to 'Learn more' in preferences.ftl to be consistent, r=flod

Comment 17

[:Gijs (he/him)]

(In reply to Francesco Lodolo [:flod] from comment #15)
> I've approved the patch, but in Lando I get "Repository is not supported by
> Lando.", which leaves me quite puzzled. Any clue?

People in #phabricator on IRC said that it was probably uploaded via the web interface rather than using moz-phab / phabsend.

haotian: thanks for the patch - in future please use https://github.com/mozilla-conduit/review/blob/master/README.md to submit it. Thank you!

Comment 18

[haotian xiang]

(In reply to :Gijs (he/him) from comment #17)
> (In reply to Francesco Lodolo [:flod] from comment #15)
> > I've approved the patch, but in Lando I get "Repository is not supported by
> > Lando.", which leaves me quite puzzled. Any clue?
> 
> People in #phabricator on IRC said that it was probably uploaded via the web
> interface rather than using moz-phab / phabsend.
> 
> haotian: thanks for the patch - in future please use
> https://github.com/mozilla-conduit/review/blob/master/README.md to submit
> it. Thank you!

Got it.

Comment 19

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/65ee8bd1ce81

Comment 20

[Sajedul Islam]

I have reproduced this bug with Nightly 65.0a1 (2018-11-26) on Windows 10, 64 Bit ! 

This bug's fix is Verified with latest Beta !

Build   ID    20181220174318
User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

[testday-20181221]

Comment 21

[Md. Majedul islam]

I have reproduced this bug with Nightly 65.0a1 (2018-11-08) on ManjaroLinux 18.0.1, 64 Bit!

This bug's fix is verified with the latest Beta!

Build ID   : 20181220174318
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0