1509972 - Reduce nsAutoPtr usage in layout/base

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Daniel Holbert [:dholbert]]

UniquePtr is preferred over nsAutoPtr these days.

Filing this bug on making the switch in several places in layout/base.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1509972 part 5: Use UniquePtr (not nsAutoPtr) to store a few local vars in nsCSSFrameConstructor. r?TYLin

This patch also gives nsCSSFrameConstructor.h its own UniquePtr include (since
we have some UniquePtr usage there, but no include).  Presumably it's already
getting the include indirectly (via some other header) right now, but it should
really include it directly if it uses the type directly.

(This leaves one nsAutoPtr usage in nsCSSFrameConstructor, for 'mNode'. We can
probably convert that one without too much trouble, but I'm not doing so yet,
in part because we intentionally leak that variable in one spot and I haven't
fully worked out the ownership transfer for that case.)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1509972 part 1: Remove unnecessary nsAutoPtr includes from files in layout/base. r?TYLin

In each file touched by this commit, there were no mentions of nsAutoPtr
besides the #include.

I verified that the folder layout/base still builds successfully in
non-unified mode after this patch, too. So, none of these files are secretly
using nsAutoPtr and depending on some other .cpp file to provide the header.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: Bug 1509972 part 2: Use UniquePtr (not nsAutoPtr) to store nsPresContext members mTextPerf and mMissingFonts. r?TYLin

Depends on D12993

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: Bug 1509972 part 3: Use UniquePtr (not nsAutoPtr) for mNext pointers in StaticPresData's "LangGroupFontPrefs" list. r?TYLin

Depends on D12994

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: Bug 1509972 part 4: Use UniquePtr (not nsAutoPtr) to store nsDocumentViewer member mAutoBeforeAndAfterPrint. r?TYLin

Depends on D12995

Comment 6

[Daniel Holbert [:dholbert]]

(I accidentally posted part 5 on its own before the other parts, so it's listed first here on bugzilla; but it's ordered correctly in the phabricator stack.)

Comment 7

[Daniel Holbert [:dholbert]]

thanks for the reviews! Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=382acefa5665b1f32a1eb26010c289c86ffdda5d

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79ccc9541536
part 1: Remove unnecessary nsAutoPtr includes from files in layout/base. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/01ef9c6e724f
part 2: Use UniquePtr (not nsAutoPtr) to store nsPresContext members mTextPerf and mMissingFonts. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/025e1c8e3cf8
part 3: Use UniquePtr (not nsAutoPtr) for mNext pointers in StaticPresData's "LangGroupFontPrefs" list. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/ffbdfd28202f
part 4: Use UniquePtr (not nsAutoPtr) to store nsDocumentViewer member mAutoBeforeAndAfterPrint. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/102cab25b07a
part 5: Use UniquePtr (not nsAutoPtr) to store a few local vars in nsCSSFrameConstructor. r=TYLin

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/79ccc9541536
https://hg.mozilla.org/mozilla-central/rev/01ef9c6e724f
https://hg.mozilla.org/mozilla-central/rev/025e1c8e3cf8
https://hg.mozilla.org/mozilla-central/rev/ffbdfd28202f
https://hg.mozilla.org/mozilla-central/rev/102cab25b07a