1510029 - Pages don't fit the screen after rotating from portrait to landscape

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Session Restore, defect, P2)

Description

[Jan Henning [:JanH]]

+++ This bug was initially created as a clone of Bug #1509552 +++

User Agent: Mozilla/5.0 (Android 7.1.1; Tablet; rv:65.0) Gecko/65.0 Firefox/65.0

Steps to reproduce:

1. Open https://github.com/mozilla-mobile
2. Request desktop site
3. Rotate to landscape


Actual results:

The page is smaller than the screen. Zooming in even slightly fixes the issue but then in portrait the page is larger than screen.


Expected results:

The page should adjust correctly.

=================================
See bug 1509552 comment 15 and 16.

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1510029 - Correctly set desktop mode viewport when creating a tab. r?esawin

The desktopMode property on Fennec's tab object is already being correctly being
preserved when (re)creating a tab [1], but we don't propagate its state to the
content window's desktop viewport mode setting.

[1] When restoring into a fresh tab, the session restore code passes the stored
desktopMode flag to addTab, whereas zombifying an existing tab destroys its
<browser>, but leaves the tab object's properties intact, so we merely need to
re-set the desktop viewport mode on the new <browser>'s content window.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a8b588c2c0b
Correctly set desktop mode viewport when creating a tab. r=esawin

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1a8b588c2c0b

Comment 4

[csheany]

It seems this landed but the issue remains.

Is there more to it?

Comment 5

[csheany]

Since it feels different I created a triplet: Bug 1523844

Comment 6

[Eliza Balazs]

Hi!
Tested this on Nexus 9 (Android 7.1.1, Tablet) on Release version 65.0.1, latest Beta build 66.0b7, latest Nightly build 67.0a1 and its not fixed.
We will change the flag for 67 to verified after Bug 1523844 is fixed.
We didn't closed as duplicate Bug 1523844 because there are useful comments related with this issue.