1510034 - Stop parsing mozconfigs in autospider.py

Status: NEW

(Core :: JavaScript Engine, enhancement, P3)

Description

[Steve Fink [:sfink] [:s:]]

This is probably the grossest remaining part of autospider.py, and should hopefully be unnecessary now. Thus quoth glandium in bug 1451409 comment 18: "autospider should just stop trying to be its own mozconfig handling, should just use mozconfigs. autospider was written back when js configure didn't support mozconfigs, but it does now."

Comment 1

[Steve Fink [:sfink] [:s:]]

I was trying to enable code coverage for the spidermonkey jobs, and immediately ran into this because I didn't really want to duplicate all of that configuration. So I figured I'd take a stab at switching to using mozconfigs, since the code coverage builds use mozconfigs.

Except the build system seems to intentionally prevent doing this.

I want autospider.py to work on local desktops in as similar a way as possible to automation builds. But local builds are banned from using in-tree mozconfigs.

For code coverage, browser/config/mozconfigs/linux64/code-coverage-debug includes ./code-coverage which sets up the needed stuff. But if I set MOZCONFIG to that file, I get the error message that I shouldn't be using in-tree mozconfigs:

  ERROR: In-tree mozconfigs make strong assumptions about and are only meant to be used by Mozilla automation.
  ERROR: Please don't use them.

Are we not supposed to be able to run anything locally if it is configured via a mozconfig file? I don't want to switch autospider.py to mozconfigs if it means it cannot be run on local desktops anymore; that's the point of the script and I don't want to lose that (we used to have many, many more instances where we couldn't reproduce automation failures on our desktops.)

(This is one where I'd like to needinfo :build-peer but can't, so I'll use glandium since I know he has opinions here.)