Closed Bug 1510126 Opened 1 year ago Closed 1 year ago

Add tools/profiler/core/vtune to the list of third-party directories

Categories

(Firefox Build System :: Lint and Formatting, enhancement)

enhancement
Not set

Tracking

(firefox-esr60 fixed, firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox-esr60 --- fixed
firefox65 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
Blocks: clang-format
Random drive-by comment: shouldn't we rather remove the only file that's under tools/profiler/core/vtune, considering we have another copy of that file in js/src/vtune?
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e23d7926d41e
Add tools/profiler/core/vtune to the list of third-party directories r=sylvestre
https://hg.mozilla.org/mozilla-central/rev/e23d7926d41e
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
(In reply to Mike Hommey [:glandium] from comment #2)
> Random drive-by comment: shouldn't we rather remove the only file that's
> under tools/profiler/core/vtune, considering we have another copy of that
> file in js/src/vtune?

Yes probably, although sharing code between js/src and code outside of it can be painful, it may be the reason why there is a separate copy already.  Please file a Core::Profiler bug?
Attached patch ESR patchSplinter Review
[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is NPOTB.

String or UUID changes made by this patch: None
Attachment #9031014 - Flags: approval-mozilla-esr60?
Comment on attachment 9031014 [details] [diff] [review]
ESR patch

OK for uplift to ESR60 as part of the clang-format project.
Attachment #9031014 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Target Milestone: Firefox 65 → mozilla65
You need to log in before you can comment on or make changes to this bug.