151023 - duplicates.cgi sort by delta sorts wrong direction

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Asa Dotzler [:asa]]

when sorting by the list of duplicates by delta the top of the list is the
fewest changes and the bottom of the list is the most changes. This is backwards
from how it used to be and a lot less useful. See this list for an example
http://bugzilla.mozilla.org/duplicates.cgi?sortby=delta&maxrows=20&changedsince=5

I think that most people will want to see the bugs which have gathered the most
duplicates at the top of the list, not the fewest.

Comment 1

[Bradley Baetz (:bbaetz)]

Maybe we should sort by the absolute value of the change?

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This should be what's wanted.

Gerv

Comment 3

[Bradley Baetz (:bbaetz)]

Comment on attachment 87421 [details] [diff] [review]
Patch v.1

r=bbaetz

We may want to consider sorting by absolute value at some point, but thats not
important now.

What happened to bmo's duplicates.cgi?

Comment 4

[Gervase Markham [:gerv]]

b.m.o's duplicates.cgi got taken offline for performance reasons. As a fun
experiment, read the code and see if you can spot the obvious problem :-) Then
check out bug 151281.

Gerv

Comment 5

[Bradley Baetz (:bbaetz)]

Yeah, that was the next bug in my list (I look at bugs chronologically). See my
comments there.

Comment 6

[Jouni Heikniemi]

Comment on attachment 87421 [details] [diff] [review]
Patch v.1

>Index: template/en/default/reports/duplicates-table.html.tmpl
>+              [% ELSE %]
>+                 [%-# Some columns start off reversed %]
>+                [% "&reverse=1" IF column.name.match('delta|count') %]

Zap that one extra space before the comment line unless there is a reason for
it. With that, r=jouni.

Comment 7

[Gervase Markham [:gerv]]

Fixed on trunk and branch.

Checking in template/en/default/reports/duplicates-table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/duplicates-table.html.tmpl,v
 <--  duplicates-table.html.tmpl
new revision: 1.3; previous revision: 1.2
done

Checking in template/en/default/reports/duplicates-table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/duplicates-table.html.tmpl,v
 <--  duplicates-table.html.tmpl
new revision: 1.1.2.2; previous revision: 1.1.2.1
done

Gerv