151024 - Sidebar history sorting loads url

Status: VERIFIED WORKSFORME

(Core Graveyard :: History: Global, defect)

Description

[Tuukka Tolvanen (sp3000)]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1a) Gecko/20020611
BuildID:    2002061120

Reproducible: Always

1. Open sidebar, history tab
2. Click on a column header to sort

Actual Results:  Sort; whatever history item happens to end up selected is loaded

Expected Results:  just sort

Comment 1

[Andrew Hagen]

Yeah. I think this is limited to when history is set to sort by group: none, as
pointed out by bug 128322 comment 71. 

I can reproduce this on 1.1 trunk 2002071914 Windows 98 if I set history to sort
by group: none. PC/all.

While it is limited in scope, this bug is bad because it loads unwanted,
unrequested URL's.

Comment 2

[Oswald Fischer]

I have this in Mozilla 1.0.1 too. The problem is in the function
historyOnClick(aEvent)in history.js contained in bin\chrome\comm.jar. My solve
for Mozilla 1.0.1: change the lines: 

if (!isContainer(gHistoryTree, row.value))
  OpenURL(false);

to:

if (!isContainer(gHistoryTree, row.value) && aEvent.clientY > 16)
  OpenURL(false);

Comment 3

[Nisheeth Ranjan]

Re-assigning to myself as fixing this bug is related to fixing bug 161546...

Comment 4

[Nisheeth Ranjan]

I tried to reproduce this bug in the 2-28-2003 Mozilla build on windows and
couldn't.  Are people out there still seeing this?  

Resolving this worksforme.  Please reopen if anyone is still seeing this.  thanks!

Comment 5

[Tuukka Tolvanen (sp3000)]

wfm too in linux 02-23, v