1510291 - Log viewer is missing the horizontal scroll bar

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Neither selecting with click and drag nor the arrow keys left and right left one scroll horizontally to e.g. see the ends of very long lines.

Example: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=214054384&repo=mozilla-central&lineNumber=91142 (needs 2/3 of 24'' screen to show whole line).

Comment 3

[Ed Morley [:emorley]]

(adjusting summary to hopefully make it stand out more in the box that Bugzilla shows people with possible duplicates)

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4316

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/3145e28ed8a96b4e54299d653be86e03242b3e95
Bug 1510291 - Fix horizontal scrollbars in Logviewer (#4316)

Comment 6

[Cameron Dawson [:camd]]

Had to add a work-around param to the LazyLog.  Filed upstream: https://github.com/mozilla-frontend-infra/react-lazylog/issues/28

Comment 7

[Hassan Ali (:hassan)]

https://github.com/mozilla-frontend-infra/react-lazylog/issues/21#issuecomment-456960726

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Hassan Ali (:hassan) from comment #7)

https://github.com/mozilla-frontend-infra/react-lazylog/issues/21#issuecomment-456960726

This issue has been fixed now in lazy-log 4.4.3. Is there anything we would have to follow-up on for Treeherder?

Comment 9

[Cameron Dawson [:camd]]

Treeherder has been updated to this latest version (actually 4.4.4 now). The arrow keys scroll left and right for me. But I'm on a mac. Does this work ok for you now, Henrik?

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It's all fine.