Closed
Bug 1510331
Opened 6 years ago
Closed 5 years ago
ASR Snippets: New button for Send to Device / Newsletter Templates
Categories
(Firefox :: New Tab Page, enhancement, P3)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox71 | --- | verified |
People
(Reporter: giorgos, Assigned: jpetto)
References
Details
(Keywords: github-merged)
The ASR Send to Device and Newsletter templates display a button on the error scene, after there has been an error communicating with basket. That button is the same from the first scene. Unfortunately the copy on that button doesn't always make sense in the error page, as it can be "Let's go!" or "Check it out!". We would like to keep the functionality but instead of displaying the button of the first scene, display a new button with the name `error_page_button_label` and the default value of `Try again`. Please also confirm that only those two templates are featuring this button.
Updated•5 years ago
|
Priority: -- → P3
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
Comment 1•5 years ago
|
||
Status: NEW → RESOLVED
Iteration: --- → 71.1 - Sept 2 - 15
Closed: 5 years ago
status-firefox71:
--- → fixed
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Updated•5 years ago
|
Assignee: nobody → jon
Updated•5 years ago
|
Comment 2•5 years ago
|
||
I have verified this issue on Latest Firefox Nightly 71.0a1(ID build:20190916155843) Windows 10 x64, Mac 10.14.5 and Arch Linux 4.16.6 x64 with the following steps:
- Trigger the "NEWSLETTER_TEST_DEFAULT" snippet from the ASRouter.
- Clicked the "Continue" button.
- I added a valid email.
- Checked the "I'm okay with Mozilla..." checkbox.
- I edited the form action event with"foo.com" and clicked the "Sign me up" button.
After following the steps from above The "Error! Try Again?" message was correctly displayed.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•