1510335 - ASR Snippets: Provide a way to preview snippets in other themes

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P3)

Description

[Giorgos Logiotatidis [:giorgos]]

Currently ASR Snippets preview always displays the default theme. We need a way to preview in other themes as well.

Comment 1

[Giorgos Logiotatidis [:giorgos]]

Hi Andrei,

I brought that up in our mtg during AH and you mentioned that it works but it doesn't work for me.

I've selected the Dark theme in Firefox and every preview link I open uses the default, light theme.

I'm testing on Linux.

Any ideas?

Comment 2

[Andrei Oprea [:andreio]]

Attachment: Bug 1510335 - ASR Snippets: Provide a way to preview snippets in other themes

Comment 3

[Andrei Oprea [:andreio]]

Comment on attachment 9051334 [details]
Bug 1510335 - ASR Snippets: Provide a way to preview snippets in other themes

This is part of a devtool feature for Snippets that allows content creators to preview snippets + content in a newtab.
By whitelisting a host (browser.newtab.activity-stream.asrouter.whitelistHosts) we fetch snippet content from a URL passed in using query parameters.
The issue here is that LightweightThemeChild.jsm is not whitelisted for about:newtab?endpoint=..., LightweightTheme:Set never fires and the newtab loaded will have the default light theme even if the browser has dark theme set.

Comment 4

[Giorgos Logiotatidis [:giorgos]]

Andrei could we get this to allow theme selection in the URL?

something like

about:newtab?endpoint=....&theme=light

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4856

Comment 6

[Andrei Oprea [:andreio]]

(In reply to GitHub Bugzilla PR Linker from comment #5)

I made a PR implementing this, waiting on review to see if there are any concerns.

Comment 7

[Giorgos Logiotatidis [:giorgos]]

I see the PR is merged, w00t!

Which release version is planned to get this?

Also how do we use this? Is there supporting documentation?

ThankS!

Comment 8

[Andrei Oprea [:andreio]]

This will be available in 68, it's not in Nightly yet (will be when this bug is closed). I'll add some documentation about it but it works as you described, no pref or config required.

about:newtab?endpoint=http://foo.com&theme=light // or "dark"

Comment 9

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/7a266c35cb30

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190407214820) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now the Snippets can be also previewed in other themes.