Closed
Bug 1510341
Opened 7 years ago
Closed 7 years ago
Display bugzilla component of a file
Categories
(Webtools :: Searchfox, enhancement)
Webtools
Searchfox
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mccr8, Assigned: kats)
References
Details
I don't know about the filing a bug part of bug 1448334, but somehow displaying the component for a file might be handy. When digging around in code while looking at stack traces from sec bugs, I often have to open a bunch of the most recent commits and see what component they are to figure out the component of a file. If this component info is easily copy-able, then it wouldn't be too hard to file a bug from there.
This assumes that the bugzilla components are filled out nicely, but maybe if this information is surfaced in a developer-visible way then people will add more files.
| Assignee | ||
Comment 1•7 years ago
|
||
Yeah I think this shouldn't be too hard. We can run `./mach file-info bugzilla-component <file>` and pass the component to the output-file binary when generating the output files. And from there it should be easy to bake it into the UI and add a link to file a bug as well.
Thoughts on where in the UI this should go? In the nav panel?
| Reporter | ||
Comment 2•7 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #1)
> Thoughts on where in the UI this should go? In the nav panel?
That is the obvious place to stick some info, though it doesn't have anything to do with navigation per se. Maybe it could go next to the file name? Though that's a bit ugly.
Comment 3•7 years ago
|
||
Maybe to the right under the search bar, where we display the commit info? I always feel there's too much space there.
| Assignee | ||
Updated•7 years ago
|
Assignee: nobody → kats
| Assignee | ||
Comment 4•7 years ago
|
||
So I added a "file a bug for this file" link in the nav panel. Do we still want the product/component to be explicitly displayed somewhere?
Flags: needinfo?(continuation)
| Reporter | ||
Comment 5•7 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #4)
> So I added a "file a bug for this file" link in the nav panel. Do we still
> want the product/component to be explicitly displayed somewhere?
Personally, I care more about being able to easily see the component than being able to file a bug easily, but you can just hover over it, so that seems okay. Maybe the text could read something like "file a bug in Core :: DOM"? But just closing this bug is okay with me.
Flags: needinfo?(continuation)
| Assignee | ||
Comment 6•7 years ago
|
||
(In reply to Andrew McCreight [:mccr8] (PTO-ish 12-22 to -30) from comment #5)
> Maybe the text could read something like "file a bug in Core ::
> DOM"?
That sounds good, I'll do that. I wasn't really happy with the current text but couldn't think of anything better at the time.
| Assignee | ||
Comment 7•7 years ago
|
||
https://github.com/mozsearch/mozsearch/pull/179
This is deployed now
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•