1510610 - Lint Error: Accessibility in Custom Views

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P5)

Description

[Emily Toop (:fluffyemily)]

If a View that overrides onTouchEvent or uses an OnTouchListener does not also implement performClick and call it when clicks are detected, the View may not handle accessibility actions properly. Logic handling the click actions should ideally be placed in View#performClick as some accessibility services invoke performClick when a click action should occur.

This issue currently affects:

GeckoView.java

Comment 1

[Emily Toop (:fluffyemily)]

Attachment: Override `performClick` for `onTouchEvents`.

This is to ensure that accessibility readers have touch events handled.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e351b1ca8fc
Override `performClick` for `onTouchEvents`. r=geckoview-reviewers,snorp

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/4e351b1ca8fc