1510615 - Lint Warning: Hardcoded reference to /sdcard

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P5)

Description

[Emily Toop (:fluffyemily)]

Your code should not reference the /sdcard path directly; instead use Environment.getExternalStorageDirectory().getPath().  

Similarly, do not reference the /data/data/ path directly; it can vary in multi-user scenarios. Instead, use Context.getFilesDir().getPath().

This issue currently affects:

CrashHandler.java
GeckoLoader.java

Comment 1

[Jimmy Tan]

Hey, can I work on this as a good first bug? Thanks :)

Comment 2

[Emily Toop (:fluffyemily)]

If you need help setting up GeckoView, you can follow our setup guides on our documentation site: https://mozilla.github.io/geckoview/contributor/.

Feel free to use the public Riot GeckoView channel to ask questions: https://chat.mozilla.org/#/room/#geckoview:mozilla.org

Comment 3

[[:owlish] 🦉 PST]

(In reply to Emily Toop (:fluffyemily) from comment #2)

If you need help setting up GeckoView, you can follow our setup guides on our documentation site: https://mozilla.github.io/geckoview/contributor/.

I have already set up my environment using that doc (it's really excellent!).

Feel free to use the public Riot GeckoView channel to ask questions: https://chat.mozilla.org/#/room/#geckoview:mozilla.org

I will, thank you!

Comment 4

[[:owlish] 🦉 PST]

Attachment: Bug 1510615 - Replace hardcoded /data/data paths or supress lint warning where not replaceable

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03fc2ea7048c
Replace hardcoded /data/data paths or supress lint warning where not replaceable r=geckoview-reviewers,snorp

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/03fc2ea7048c