Closed
Bug 1510621
Opened 6 years ago
Closed 5 years ago
Investigate to see if toString optimization for bigints representable as doubles is worthwhile
Categories
(Core :: JavaScript Engine, defect, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
DUPLICATE
of bug 1523888
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | affected |
People
(Reporter: wingo, Assigned: wingo)
References
Details
The initial version of the BigInt toString won't take advantage of cached strings for common small numbers like 1 and so on. Perhaps this should be added. See https://phabricator.services.mozilla.com/D10046?id=29106#inline-52247.
|
||
Updated•6 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•5 years ago
|
||
I think I can close this. IIRC this followup was filed in response to BigInt::toString not taking advantage of the optimizations for converting int32 values to strings. However after bug 1523888 landed, we do go through this code (for base 10). So, I think this is done. Please reopen if I misunderstood.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•