Add reftests that exericse different sticky-position scenarios wrt enclosing scrollframe and reference frames

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P2
normal
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: kats, Assigned: kats)

Tracking

Other Branch
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

Spinoff from https://phabricator.services.mozilla.com/D13081#323451

Bug 1503447 made some changes to get rid of the stacking context origin property passed to WR. However in order to pull this off it had to twist around some of the sticky positioning handling code on the gecko side. In doing so we discovered that there are scenarios that our existing reftests don't cover, so we should add explicit tests for them.

In particular we should add a reftests that cover the scenarios at [1] and [2] (4 reftests in total, there's two per URL). The first two exercise the case where there's a sticky item inside a transformed element inside a scrollframe. The next two exercise the case where there's a sticky item inside a scrollframe inside a transformed element.

[1] https://mozilla.staktrace.com/bug/1503447-1.html
[2] https://mozilla.staktrace.com/bug/1503447-2.html
Summary: Add reftest for case where sticky item and enclosing scrollframe share the same transformed reference frame → Add reftests that exericse different sticky-position scenarios wrt enclosing scrollframe and reference frames
Whoops, the failure on Linux/Android is because the scrollbars don't cover the text like they do on win/mac. Updated try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e45b40af424825cc24eb2685b452ccc045cca03e

I'm expecting this to have one Android failure which is fuzzable. I just need to see the failure to know the fuzz values. Rest should be green.
Priority: -- → P2
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e79c6da7b0fe
Add reftests for various scenarios involving sticky items inside scrollframes and transforms. r=kvark
https://hg.mozilla.org/mozilla-central/rev/e79c6da7b0fe
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.