1510639 - Add reftests that exericse different sticky-position scenarios wrt enclosing scrollframe and reference frames

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P2)

Description

[Kartikaya Gupta (email:[e-mail])]

Spinoff from https://phabricator.services.mozilla.com/D13081#323451

Bug 1503447 made some changes to get rid of the stacking context origin property passed to WR. However in order to pull this off it had to twist around some of the sticky positioning handling code on the gecko side. In doing so we discovered that there are scenarios that our existing reftests don't cover, so we should add explicit tests for them.

In particular we should add a reftests that cover the scenarios at [1] and [2] (4 reftests in total, there's two per URL). The first two exercise the case where there's a sticky item inside a transformed element inside a scrollframe. The next two exercise the case where there's a sticky item inside a scrollframe inside a transformed element.

[1] https://mozilla.staktrace.com/bug/1503447-1.html
[2] https://mozilla.staktrace.com/bug/1503447-2.html

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ef73b940d4026ac07b8009d63c6bd71611c066b

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Whoops, the failure on Linux/Android is because the scrollbars don't cover the text like they do on win/mac. Updated try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e45b40af424825cc24eb2685b452ccc045cca03e

I'm expecting this to have one Android failure which is fuzzable. I just need to see the failure to know the fuzz values. Rest should be green.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1510639 - Add reftests for various scenarios involving sticky items inside scrollframes and transforms. r?kvark

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e79c6da7b0fe
Add reftests for various scenarios involving sticky items inside scrollframes and transforms. r=kvark

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/e79c6da7b0fe