Lint Error: Missing Permissions

RESOLVED FIXED in Firefox 66

Status

defect
P5
normal
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: fluffyemily, Assigned: fluffyemily)

Tracking

(Blocks 1 bug, {good-first-bug})

unspecified
mozilla66
Unspecified
Android
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

6 months ago
This check scans through your code and libraries and looks at the APIs being used, and checks this against the set of permissions required to access those APIs. If the code using those APIs is called at runtime, then the program will crash.  

Furthermore, for permissions that are revocable (with targetSdkVersion 23), client code must also be prepared to handle the calls throwing an exception if the user rejects the request for permission at runtime.

Affected classes:

GeckoAppShell
GeckoNetworkManager
Keywords: good-first-bug
OS: Unspecified → Android
Priority: -- → P5
Assignee

Comment 1

5 months ago
This is because these persmissions are the responsibility of the embedding app to request,not GeckoView's.
Assignee

Updated

5 months ago
Assignee: nobody → etoop

Updated

5 months ago
Product: Firefox for Android → GeckoView

Comment 2

5 months ago
Pushed by etoop@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/589569dbbb63
Suppress MissingPermission warnings. r=geckoview-reviewers,snorp

Comment 3

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/589569dbbb63
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.