1510651 - Lint Error: Too Long Log Tags

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P5)

Description

[Emily Toop (:fluffyemily)]

Log tags are only allowed to be at most 23 tag characters long.

Affected Classes:

BasicSelectionActionDelegate
DynamicToolbarAnimator
GeckoServiceChildProcess
GeckoSystemStateListener
HardwareCodecCapabilityUtils
RemoteMediaDrmBridge
RemoteMediaDrmBridgeStub

Comment 1

[Timm]

Hi I would like to pick this up as one of my first bugs, I just wanted some follow up for this. Should I try and abbreviate the names or totally rename them (I dont want to rename them and have them lose their definitive meaning).

Any pointers on how to approach this would be appreciated, thanks.

Comment 2

[Emily Toop (:fluffyemily)]

I would say simply to truncate the LOGTAG value until it is under the 23 character limit.

In the case of RemoteMediaDrmBridge and RemoteMediaDrmBridgeStub where simple truncation would leave to identical LOGTAGs, truncate RemoteMediaDrmBridge and remove Bridge from RemoteMediaDrmBridgeStub

RemoteMediaDrmBridge -> GeckoRemoteMediaDrmBrid
RemoteMediaDrmBridgeStub -> GeckoRemoteMediaDrmStub

Comment 3

[Chris Peterson [:cpeterson]]

Enhancements should have severity N/A.

Comment 4

[Logan Rosen [:Logan]]

This appears to have been fixed in this revision from 2019. Android Studio is showing no violations in the codebase. Closing this.