1510660 - Lint Warning: Use apply() on SharedPreferences

Status: RESOLVED FIXED

(GeckoView :: General, task, P5)

Description

[Emily Toop (:fluffyemily)]

Consider using apply() instead of commit on shared preferences. Whereas commit blocks and writes its data to persistent storage immediately, apply will handle it in the background.

Affected Classes:

GeckoAppShell
GeckoProfile.

Initial look at these suggests that we are calling `commit` as we desire synchronous writes and so here we probably just want to suppress the warnings.

Comment 1

[EvaNanyonga]

I would like to take up this issue. Is that alright?

Comment 2

[Emily Toop (:fluffyemily)]

Hi EvaNanyonga, absolutely!

If you need to get up and running with GeckoView you can refer to our getting started guide here: https://mozilla.github.io/geckoview/tutorials/geckoview-quick-start.html

You can run the lint using ./mach android lint after you set up the workspace using the guide linked above.

Feel free to ask any questions here on the bug or on IRC at #mobile.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 4

[Chris Peterson [:cpeterson]]

Enhancements should have severity N/A.

Comment 5

[Logan Rosen [:Logan]]

Attachment: Bug 1510660 - suppress lint warning for SharedPreferences.apply() r?#geckoview-reviewers

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac40edb9fde1
suppress lint warning for SharedPreferences.apply() r=geckoview-reviewers,owlish DONTBUILD

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ac40edb9fde1