1510662 - Lint Warning: Using Private APIs

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P5)

Description

[Emily Toop (:fluffyemily)]

Using reflection to access hidden/private Android APIs is not safe; it will often not work on devices from other vendors, and it may suddenly stop working (if the API is removed) or crash spectacularly (if the API behavior changes, since there are no guarantees for compatibility).

Affected Classes:

SharedMemory
Util

Comment 1

[Chris Peterson [:cpeterson]]

Enhancements should have severity N/A.

Comment 2

[Ankit Anand]

I wish to work on this issue.

Comment 3

[Makoto Kato [:m_kato]]

We use reflection in the following. This needs @SuppressLint("DiscouragedPrivateApi").

• https://searchfox.org/mozilla-central/rev/42747dfd314e4c939dc7c33a13e1a2fddf4926fc/mobile/android/geckoview/src/main/java/org/mozilla/gecko/mozglue/SharedMemory.java#27
• https://searchfox.org/mozilla-central/rev/42747dfd314e4c939dc7c33a13e1a2fddf4926fc/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/OverscrollEdgeEffect.java#46

Comment 4

[Ankit Anand]

Shall I change @SuppressLint("PrivateApi") to @SuppressLint({"PrivateApi", "DiscouragedPrivateApi"}) in Util.java ?

• https://searchfox.org/mozilla-central/source/mobile/android/exoplayer2/src/main/java/org/mozilla/thirdparty/com/google/android/exoplayer2/util/Util.java#2052

Comment 5

[Makoto Kato [:m_kato]]

(In reply to Ankit Anand from comment #4)

Shall I change @SuppressLint("PrivateApi") to @SuppressLint({"PrivateApi", "DiscouragedPrivateApi"}) in Util.java ?

• https://searchfox.org/mozilla-central/source/mobile/android/exoplayer2/src/main/java/org/mozilla/thirdparty/com/google/android/exoplayer2/util/Util.java#2052

No, don't touch this file since under mobile/android/exoplayer2 is third party source code.

Comment 6

[Ankit Anand]

Attachment: Bug 1510662 - Suppress Lint Warning: Using Private APIs. r=m_kato,#geckoview-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75ea2b4ddd60
Suppress Lint Warning: Using Private APIs. r=m_kato,geckoview-reviewers

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/75ea2b4ddd60